Change operation IDs to hashed values

Author: nvasiu

sdk/src/main/java/software/amazon/lambda/durable/DurableContext.java

@@ -2,6 +2,7 @@
 // SPDX-License-Identifier: Apache-2.0
 package software.amazon.lambda.durable;
 
+import com.amazonaws.services.lambda.runtime.Context;
 import java.nio.charset.StandardCharsets;
 import java.security.MessageDigest;
 import java.security.NoSuchAlgorithmException;
@@ -11,11 +12,7 @@
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.function.Function;
 import java.util.function.Supplier;
-
 import org.slf4j.LoggerFactory;
-
-import com.amazonaws.services.lambda.runtime.Context;
-
 import software.amazon.lambda.durable.execution.ExecutionManager;
 import software.amazon.lambda.durable.logging.DurableLogger;
 import software.amazon.lambda.durable.operation.CallbackOperation;
@@ -316,22 +313,20 @@ public DurableLogger getLogger() {
     }
 
     /**
-     * Get the next operationId. 
-	 * Returns a globally unique operation ID by hashing a sequential operation counter.
-	 * For root contexts, the counter value is hashed directly (e.g. "1", "2", "3").
-	 * For child contexts, the values are prefixed with the parent hashed contextId
-	 * (e.g. "<hash>-1", "<hash>-2" inside parent context <hash>).
-	 * This matches the JavaScript SDK's stepPrefix convention and prevents ID collisions in checkpoint batches.
+     * Get the next operationId. Returns a globally unique operation ID by hashing a sequential operation counter. For
+     * root contexts, the counter value is hashed directly (e.g. "1", "2", "3"). For child contexts, the values are
+     * prefixed with the parent hashed contextId (e.g. "<hash>-1", "<hash>-2" inside parent context <hash>). This
+     * matches the JavaScript SDK's stepPrefix convention and prevents ID collisions in checkpoint batches.
      */
     private String nextOperationId() {
         var counter = String.valueOf(operationCounter.incrementAndGet());
-		var rawId = getContextId() != null ? getContextId() + "-" + counter : counter;
-		try {
-			var messageDigest = MessageDigest.getInstance("SHA-256");
-			var hash = messageDigest.digest(rawId.getBytes(StandardCharsets.UTF_8));
-			return HexFormat.of().formatHex(hash);
-		} catch (NoSuchAlgorithmException e) {
-			throw new RuntimeException("failed to get next operation id, SHA-256 not available", e);
-		}
+        var rawId = getContextId() != null ? getContextId() + "-" + counter : counter;
+        try {
+            var messageDigest = MessageDigest.getInstance("SHA-256");
+            var hash = messageDigest.digest(rawId.getBytes(StandardCharsets.UTF_8));
+            return HexFormat.of().formatHex(hash);
+        } catch (NoSuchAlgorithmException e) {
+            throw new RuntimeException("failed to get next operation id, SHA-256 not available", e);
+        }
     }
 }

sdk/src/test/java/software/amazon/lambda/durable/DurableContextTest.java

@@ -1,13 +1,13 @@
 // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
 package software.amazon.lambda.durable;
+
 import static org.junit.jupiter.api.Assertions.*;
+
 import java.time.Duration;
 import java.util.ArrayList;
 import java.util.List;
-
 import org.junit.jupiter.api.Test;
-
 import software.amazon.awssdk.services.lambda.model.*;
 import software.amazon.lambda.durable.execution.ExecutionManager;
 import software.amazon.lambda.durable.execution.SuspendExecutionException;
@@ -131,8 +131,10 @@ void testWait() {
     @Test
     void testWaitReplay() {
         // Create context with completed wait operation
-        var existingOp =
-                Operation.builder().id(TestUtils.hashOperationId("1")).status(OperationStatus.SUCCEEDED).build();
+        var existingOp = Operation.builder()
+                .id(TestUtils.hashOperationId("1"))
+                .status(OperationStatus.SUCCEEDED)
+                .build();
         var context = createTestContext(List.of(existingOp));
 
         // Wait should complete immediately (no exception)
@@ -177,8 +179,10 @@ void testCombinedReplay() throws Exception {
                 .status(OperationStatus.SUCCEEDED)
                 .stepDetails(StepDetails.builder().result("100").build())
                 .build();
-        var waitOp =
-                Operation.builder().id(TestUtils.hashOperationId("3")).status(OperationStatus.SUCCEEDED).build();
+        var waitOp = Operation.builder()
+                .id(TestUtils.hashOperationId("3"))
+                .status(OperationStatus.SUCCEEDED)
+                .build();
         var context = createTestContext(List.of(syncOp, asyncOp, waitOp));
 
         // All operations should replay from cache

sdk/src/test/java/software/amazon/lambda/durable/DurableExecutionTest.java

@@ -2,17 +2,16 @@
 // SPDX-License-Identifier: Apache-2.0
 package software.amazon.lambda.durable;
 
-import java.util.List;
-import java.util.concurrent.ExecutorService;
-
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertTrue;
-import org.junit.jupiter.api.Test;
 
+import java.util.List;
+import java.util.concurrent.ExecutorService;
+import org.junit.jupiter.api.Test;
 import software.amazon.awssdk.services.lambda.model.CheckpointUpdatedExecutionState;
 import software.amazon.awssdk.services.lambda.model.ExecutionDetails;
 import software.amazon.awssdk.services.lambda.model.Operation;

sdk/src/test/java/software/amazon/lambda/durable/ReplayValidationTest.java

@@ -2,15 +2,14 @@
 // SPDX-License-Identifier: Apache-2.0
 package software.amazon.lambda.durable;
 
-import java.time.Duration;
-import java.util.List;
-import java.util.stream.Stream;
-
 import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertTrue;
-import org.junit.jupiter.api.Test;
 
+import java.time.Duration;
+import java.util.List;
+import java.util.stream.Stream;
+import org.junit.jupiter.api.Test;
 import software.amazon.awssdk.services.lambda.model.CheckpointUpdatedExecutionState;
 import software.amazon.awssdk.services.lambda.model.Operation;
 import software.amazon.awssdk.services.lambda.model.OperationStatus;

sdk/src/test/java/software/amazon/lambda/durable/TestUtils.java

@@ -2,18 +2,16 @@
 // SPDX-License-Identifier: Apache-2.0
 package software.amazon.lambda.durable;
 
-import java.nio.charset.StandardCharsets;
-import java.security.MessageDigest;
-import java.security.NoSuchAlgorithmException;
-
 import static org.mockito.ArgumentMatchers.*;
 import static org.mockito.Mockito.*;
 
+import java.nio.charset.StandardCharsets;
+import java.security.MessageDigest;
+import java.security.NoSuchAlgorithmException;
 import java.util.ArrayList;
 import java.util.HexFormat;
 import java.util.List;
 import java.util.UUID;
-
 import software.amazon.awssdk.services.lambda.model.*;
 import software.amazon.lambda.durable.client.DurableExecutionClient;
 
@@ -68,13 +66,13 @@ public static DurableExecutionClient createMockClient() {
         return client;
     }
 
-	public static String hashOperationId(String rawId) {
-		try {
-			var messageDigest = MessageDigest.getInstance("SHA-256");
-			var hash = messageDigest.digest(rawId.getBytes(StandardCharsets.UTF_8));
-			return HexFormat.of().formatHex(hash);
-		} catch (NoSuchAlgorithmException e) {
-			throw new AssertionError("SHA-256 not available", e);
-		}
-	}
+    public static String hashOperationId(String rawId) {
+        try {
+            var messageDigest = MessageDigest.getInstance("SHA-256");
+            var hash = messageDigest.digest(rawId.getBytes(StandardCharsets.UTF_8));
+            return HexFormat.of().formatHex(hash);
+        } catch (NoSuchAlgorithmException e) {
+            throw new AssertionError("SHA-256 not available", e);
+        }
+    }
 }