Skip to content

Commit 9bd2238

Browse files
jeanplevesquejeanplevesque
authored
Merge pull request #76 from nventive/dev/jpl/cleanup
ci!: Switch to mainline mode for gitversion and update PR template.
2 parents ecab334 + 852ec3a commit 9bd2238

7 files changed

Lines changed: 59 additions & 101 deletions

File tree

‎.dependabot/config.yml‎

Lines changed: 0 additions & 13 deletions
This file was deleted.

‎.github/PULL_REQUEST_TEMPLATE.md‎

Lines changed: 43 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1,42 +1,50 @@
11
GitHub Issue: #
2-
<!-- Link to relevant GitHub issue if applicable.
3-
All PRs should be associated with an issue -->
42

53
## Proposed Changes
6-
<!-- Please un-comment one ore more that apply to this PR -->
7-
8-
<!-- - Bug fix -->
9-
<!-- - Feature -->
10-
<!-- - Code style update (formatting) -->
11-
<!-- - Refactoring (no functional changes, no api changes) -->
12-
<!-- - Build or CI related changes -->
13-
<!-- - Documentation content changes -->
14-
<!-- - Other, please describe: -->
15-
16-
17-
## What is the current behavior?
18-
<!-- Please describe the current behavior that you are modifying,
19-
or link to a relevant issue. -->
20-
21-
22-
## What is the new behavior?
23-
<!-- Please describe the new behavior after your modifications. -->
24-
25-
26-
## Checklist
27-
28-
Please check if your PR fulfills the following requirements:
29-
30-
- [ ] Documentation has been added/updated
31-
- [ ] Automated Unit / Integration tests for the changes have been added/updated
32-
- [ ] Contains **NO** breaking changes
33-
- [ ] Updated the Changelog
34-
- [ ] Associated with an issue
35-
36-
<!-- If this PR contains a breaking change, please describe the impact
37-
and migration path for existing applications below. -->
38-
4+
<!-- Please check one or more that apply to this PR. -->
5+
6+
- [ ] Bug fix
7+
- [ ] Feature
8+
- [ ] Code style update (formatting)
9+
- [ ] Refactoring (no functional changes, no api changes)
10+
- [ ] Build or CI related changes
11+
- [ ] Documentation content changes
12+
- [ ] Other, please describe:
13+
14+
## Description
15+
16+
<!-- Please describe the changes that this PR introduces. -->
17+
18+
19+
## Impact on version
20+
<!-- Please select one or more based on your commits. -->
21+
22+
- [ ] **Major** (Public API was modified.)
23+
- Public constructs (class, struct, delegate, enum, etc.) were removed or renamed.
24+
- Public members were removed or renamed.
25+
- Public method signatures were changed or renamed.
26+
- [ ] **Minor** (Public API was extended.)
27+
- Public constructs, members, or overloads were added.
28+
- [ ] **Patch** (Public API was unchanged.)
29+
- A bug in behavior was fixed.
30+
- Documentation was changed.
31+
- [ ] **None** (The library is unchanged.)
32+
- Only code under the `build` folder was changed.
33+
- Only code under the `.github` folder was changed.
34+
35+
## PR Checklist
36+
37+
- [ ] Your conventional commits are aligned with the **Impact on version** section.
38+
- [ ] Documentation is up to date.
39+
- Content of `README.md` is up to date.
40+
- XML documentation is up to date.
41+
- [ ] The [BREAKING_CHANGES.md](../BREAKING_CHANGES.md) document is up to date.
42+
- Create a new Major.0.0 header if you do a **Major** change and list the breaking changes.
43+
- [ ] Tested on all relevant platforms
3944

4045
## Other information
46+
4147
<!-- Please provide any additional information if necessary -->
4248

49+
## Internal Issue (If applicable):
50+
<!-- Link to relevant internal issue if applicable. All PRs should be associated with an issue (GitHub issue or internal) -->

‎CHANGELOG.md‎

Lines changed: 0 additions & 24 deletions
This file was deleted.

‎README.md‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -189,11 +189,6 @@ On iOS, the method removes the encrypted data from the `SecKeyChain`.
189189

190190
Please consult the [BREAKING CHANGES](BREAKING_CHANGES.md) for more information about breaking changes history.
191191

192-
## Changelog
193-
194-
Please consult the [CHANGELOG](CHANGELOG.md) for more information about version
195-
history.
196-
197192
## License
198193

199194
This project is licensed under the Apache 2.0 license - see the

‎build/gitversion.yml‎

Lines changed: 12 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,27 @@
1+
# The version is driven by conventional commits via xxx-version-bump-message.
2+
# Anything merged to main creates a new stable version.
3+
# Only builds from main and feature/* are pushed to nuget.org.
4+
15
assembly-versioning-scheme: MajorMinorPatch
2-
mode: ContinuousDeployment
3-
next-version: 0.4.0
6+
mode: MainLine
7+
next-version: '' # Use git tags to set the base version.
48
continuous-delivery-fallback-tag: ""
5-
increment: none # Disabled as it is not used. Saves time on the GitVersion step
9+
commit-message-incrementing: Enabled
10+
major-version-bump-message: "^(build|chore|ci|docs|feat|fix|perf|refactor|revert|style|test)(\\([\\w\\s-]*\\))?(!:|:.*\\n\\n((.+\\n)+\\n)?BREAKING CHANGE:\\s.+)"
11+
minor-version-bump-message: "^(feat)(\\([\\w\\s-]*\\))?:"
12+
patch-version-bump-message: "^(build|chore|docs|fix|perf|refactor|revert|style|test)(\\([\\w\\s-]*\\))?:"
13+
no-bump-message: "^(ci)(\\([\\w\\s-]*\\))?:" # You can use the "ci" type to avoid bumping the version when your changes are limited to the build or .github folders.
614
branches:
715
main:
816
regex: ^master$|^main$
9-
tag: dev
10-
increment: none
11-
beta:
12-
regex: release/beta/
13-
tag: beta
14-
increment: none
15-
source-branches: [main]
16-
stable:
17-
regex: release/stable/
1817
tag: ''
19-
increment: none
20-
source-branches: [main]
2118
dev:
2219
regex: dev/.*?/(.*?)
2320
tag: dev.{BranchName}
2421
source-branches: [main]
25-
projects:
26-
regex: projects/(.*?)
27-
tag: proj-{BranchName}
28-
source-branches: [main]
2922
feature:
3023
tag: feature.{BranchName}
3124
regex: feature/(.*?)
32-
source-branches: ['main']
33-
increment: none
25+
source-branches: [main]
3426
ignore:
3527
sha: []

‎src/BiometryService.Abstractions/BiometryService.Abstractions.csproj‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@
77
<Company>nventive</Company>
88
<AssemblyName>BiometryService.Abstractions</AssemblyName>
99
<PackageId>BiometryService.Abstractions</PackageId>
10-
<Description>BiometryService.Abstractions</Description>
10+
<Description>A unified API for biometry on iOS, Android, and Windows.</Description>
1111
<GenerateDocumentationFile>true</GenerateDocumentationFile>
1212
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
1313
<PackageProjectUrl>https://github.com/nventive/BiometryService</PackageProjectUrl>
1414
<PackageReadmeFile>README.md</PackageReadmeFile>
15-
<PackageTags>biometry;mvvm;maui;winui;ios;android;xamarin;uwp</PackageTags>
15+
<PackageTags>biometry;FaceID;TouchID;Fingerprint;mvvm;maui;winui;ios;android;xamarin;uwp</PackageTags>
1616
</PropertyGroup>
1717

1818
<!-- Needed for Source Link support. -->

‎src/BiometryService/BiometryService.csproj‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77
<Company>nventive</Company>
88
<AssemblyName>BiometryService</AssemblyName>
99
<PackageId>BiometryService</PackageId>
10-
<Description>BiometryService</Description>
10+
<Description>A unified API for biometry on iOS, Android, and Windows.</Description>
1111
<GenerateDocumentationFile>true</GenerateDocumentationFile>
12-
<PackageTags>biometry;mvvm;maui;winui;ios;android;xamarin;uwp</PackageTags>
12+
<PackageTags>biometry;FaceID;TouchID;Fingerprint;mvvm;maui;winui;ios;android;xamarin;uwp</PackageTags>
1313
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
1414
<PackageProjectUrl>https://github.com/nventive/BiometryService</PackageProjectUrl>
1515
<PackageReadmeFile>README.md</PackageReadmeFile>

0 commit comments

Comments
 (0)