fix: improve logging and apply suggested improvements

Author: mohamedsedkiyouzbechi

package.json

@@ -78,8 +78,8 @@
         },
         "promptitude.syncInstructions": {
           "type": "boolean",
-          "default": true,
-          "description": "Sync instruction prompts",
+          "default": false,
+          "description": "Sync instructions",
           "order": 3
         },
         "promptitude.syncPrompt": {

src/configManager.ts

@@ -4,7 +4,6 @@ import { GitProvider } from './utils/gitProvider';
 import { Logger } from './utils/logger';
 import * as os from 'os';
 import * as path from 'path';
-import * as fs from 'fs';
 
 export interface SyncFrequency {
     startup: number;
@@ -61,7 +60,7 @@ export class ConfigManager {
                         `Removed ${repository.length - uniqueArray.length} duplicate repository URL(s) from configuration.`
                     );
                 }, (error) => {
-                    this.logger.error('Failed to update repositories configuration', error);
+                    this.logger.error('Failed to update repositories configuration', error instanceof Error ? error : undefined);
                     vscode.window.showWarningMessage(
                         `Found ${repository.length - uniqueArray.length} duplicate repository URL(s) but failed to update configuration. Please remove duplicates manually.`
                     );

src/storage/repositoryStorage.ts

@@ -49,7 +49,11 @@ export function getRepositoryStorageDirectory(context?: vscode.ExtensionContext)
     }
 
     // Fallback: use platform-specific globalStorage path
-    const extensionId = 'logientnventive.promptitude-extension';
+    const packageJson = require('../../package.json') as { publisher?: string; name?: string };
+    const extensionId =
+        packageJson?.publisher && packageJson?.name
+            ? `${packageJson.publisher}.${packageJson.name}`
+            : 'logientnventive.promptitude-extension';
     let globalStoragePath: string;
 
     switch (process.platform) {

src/syncManager.ts

@@ -1,6 +1,5 @@
 import * as vscode from 'vscode';
 import * as path from 'path';
-import * as os from 'os';
 import { ConfigManager } from './configManager';
 import { StatusBarManager, SyncStatus } from './statusBarManager';
 import { Logger } from './utils/logger';
@@ -811,7 +810,7 @@ export class SyncManager {
             this.logger.debug(`Attempting to create symlink...`);
             // On Windows, use 'file' type; on Unix, type parameter is optional but 'file' works
             await fs.symlink(sourcePath, targetPath, 'file');
-            this.logger.info(`✅ Created symlink: ${sourcePath} -> ${targetPath}`);
+            this.logger.debug(`✅ Created symlink: ${sourcePath} -> ${targetPath}`);
         } catch (symlinkError: any) {
             this.logger.debug(`Symlink creation failed with code: ${symlinkError?.code}`);
             // Symlink creation failed (likely Windows without admin/dev mode)
@@ -855,11 +854,11 @@ export class SyncManager {
 
                 if (stats.isSymbolicLink()) {
                     await vscode.workspace.fs.delete(vscode.Uri.file(targetPath));
-                    this.logger.info(`✅ Removed symlink: ${targetPath}`);
+                    this.logger.debug(`✅ Removed symlink: ${targetPath}`);
                 } else if (process.platform === 'win32') {
                     // On Windows, we may have copied files instead of symlinks
                     await vscode.workspace.fs.delete(vscode.Uri.file(targetPath));
-                    this.logger.info(`✅ Removed file copy (Windows fallback): ${targetPath}`);
+                    this.logger.debug(`✅ Removed file copy (Windows fallback): ${targetPath}`);
                 } else {
                     this.logger.warn(`File exists but is not a symlink: ${targetPath}`);
                 }
@@ -972,7 +971,7 @@ export class SyncManager {
                                     await fs.unlink(fullPath);
                                     await this.createPromptSymlink(newSourcePath, fullPath);
                                     fixedCount++;
-                                    this.logger.info(`Fixed broken symlink: ${entry.name}`);
+                                    this.logger.debug(`Fixed broken symlink: ${entry.name}`);
                                 } else {
                                     this.logger.warn(`Cannot fix broken symlink ${entry.name}: source file not found at ${newSourcePath}`);
                                 }
@@ -1079,13 +1078,13 @@ export class SyncManager {
 
         try {
             const repoPath = this.getRepositoryPath(repositoryUrl);
-            this.logger.info(`Repository storage path: ${repoPath}`);
+            this.logger.debug(`Repository storage path: ${repoPath}`);
 
             const sourcePath = this.fileSystem.joinPath(repoPath, promptPath);
-            this.logger.info(`Source file path: ${sourcePath}`);
+            this.logger.debug(`Source file path: ${sourcePath}`);
 
             const sourceExists = await this.fileSystem.fileExists(sourcePath);
-            this.logger.info(`Source file exists: ${sourceExists}`);
+            this.logger.debug(`Source file exists: ${sourceExists}`);
 
             if (!sourceExists) {
                 const errorMsg = `Source file does not exist: ${sourcePath}`;
@@ -1095,13 +1094,13 @@ export class SyncManager {
 
             // Generate unique workspace name if there are conflicts
             const workspaceName = await this.getUniqueWorkspaceName(promptPath, repositoryUrl);
-            this.logger.info(`Workspace name: ${workspaceName}`);
+            this.logger.debug(`Workspace name: ${workspaceName}`);
 
             // Create target path directly in User/prompts/ (no subdirectories)
             const promptsDir = this.config.getPromptsDirectory();
-            this.logger.info(`Prompts directory: ${promptsDir}`);
+            this.logger.debug(`Prompts directory: ${promptsDir}`);
             const targetPath = this.fileSystem.joinPath(promptsDir, workspaceName);
-            this.logger.info(`Target path: ${targetPath}`);
+            this.logger.debug(`Target path: ${targetPath}`);
 
             await this.createPromptSymlink(sourcePath, targetPath);
             this.logger.info(`✅ Successfully activated prompt: ${promptPath} as ${workspaceName}`);
@@ -1120,24 +1119,6 @@ export class SyncManager {
         }
     }
 
-    /**
-     * Determine prompt type from filename
-     */
-    private determinePromptType(fileName: string): 'agents' | 'instructions' | 'prompts' {
-        const lowerName = fileName.toLowerCase();
-
-        // Support both 'agents' and legacy 'chatmode' naming
-        if (lowerName.includes('agent') || lowerName.includes('chatmode') || lowerName.includes('chat-mode')) {
-            return 'agents';
-        }
-
-        if (lowerName.includes('instruction') || lowerName.includes('guide')) {
-            return 'instructions';
-        }
-
-        return 'prompts';
-    }
-
     /**
      * Deactivate a prompt by removing its symlink
      * @param promptPath The workspace filename (may include repository identifier)
@@ -1154,7 +1135,9 @@ export class SyncManager {
             this.logger.error(`Failed to deactivate prompt: ${promptPath}`, error instanceof Error ? error : undefined);
             throw error;
         }
-    }    /**
+    }
+
+    /**
      * Clean up orphaned regular files in prompts directory that should be symlinks
      * Regular files that exist in repository storage should be removed from workspace
      */
@@ -1211,7 +1194,10 @@ export class SyncManager {
                         // On Windows, check if this is actually an active prompt (even if not a symlink)
                         if (process.platform === 'win32' && this.treeProvider) {
                             const allPrompts = this.treeProvider.getAllPrompts();
-                            const isActive = allPrompts.some(p => p.name === entry.name && p.active);
+                            // Check both p.name and p.workspaceName to handle disambiguated files (e.g., prompt@org-repo.md)
+                            const isActive = allPrompts.some(p => 
+                                (p.name === entry.name || p.workspaceName === entry.name) && p.active
+                            );
                             if (isActive) {
                                 this.logger.debug(`Keeping active Windows file copy: ${entry.name}`);
                                 continue;

src/ui/promptCardsWebview.ts

@@ -182,6 +182,7 @@ export class PromptCardsWebviewProvider implements vscode.WebviewViewProvider {
             --vscode-descriptionForeground: var(--vscode-descriptionForeground);
             
             /* Category colors */
+            --agents-color: #4CAF50;
             --chatmode-color: #4CAF50;
             --instructions-color: #2196F3;
             --prompts-color: #FF9800;
@@ -982,7 +983,7 @@ export class PromptCardsWebviewProvider implements vscode.WebviewViewProvider {
 
         function renderPromptCard(prompt) {
             const typeIcon = getTypeIcon(prompt.type);
-            // Escape backslashes in paths for JavaScript strings (Windows compatibility)
+            // Escape characters in paths for JavaScript single-quoted strings (Windows compatibility)
             const escapedPath = prompt.path.replace(/\\\\/g, '\\\\\\\\');
             return \`
                 <div class="prompt-card \${prompt.type} \${prompt.active ? 'active' : ''}" onclick="viewPrompt('\${escapedPath}')">
@@ -1012,7 +1013,7 @@ export class PromptCardsWebviewProvider implements vscode.WebviewViewProvider {
 
         function getTypeIcon(type) {
             switch(type) {
-                case 'chatmode': return '💬';
+                case 'agents': return '💬';
                 case 'instructions': return '📖';
                 case 'prompts': return '⚡';
                 default: return '📄';

src/ui/promptDetailsWebview.ts

@@ -79,11 +79,11 @@ export class PromptDetailsWebviewProvider implements vscode.WebviewViewProvider
         }
 
         try {
-            this.logger.info(`showPrompt called for: ${prompt.name}, active: ${prompt.active}, repositoryUrl: ${prompt.repositoryUrl}`);
+            this.logger.debug(`showPrompt called for: ${prompt.name}, active: ${prompt.active}, repositoryUrl: ${prompt.repositoryUrl}`);
 
             // Compute the actual file path
             const actualPath = this.getActualFilePath(prompt);
-            this.logger.info(`Actual path resolved to: ${actualPath}`);
+            this.logger.debug(`Actual path resolved to: ${actualPath}`);
 
             const content = await this.fileSystem.readFileContent(actualPath);
             const metadata = await this.getPromptMetadata(prompt);

src/ui/promptTreeProvider.ts

@@ -1,7 +1,6 @@
 import * as vscode from 'vscode';
 import * as path from 'path';
 import * as fs from 'fs';
-import * as os from 'os';
 import { ConfigManager } from '../configManager';
 import { FileSystemManager } from '../utils/fileSystem';
 import { Logger } from '../utils/logger';
@@ -409,8 +408,14 @@ export class PromptTreeDataProvider implements vscode.TreeDataProvider<PromptTre
                         isActive = normalizedTarget === normalizedRepoPath;
                     } else if (process.platform === 'win32') {
                         // On Windows, it might be a file copy (fallback when symlinks aren't available)
-                        // Consider it active if the file exists in workspace and matches this repository
-                        isActive = true;
+                        // Verify content matches to ensure it's actually from this repository
+                        try {
+                            const workspaceContent = await this.fileSystem.readFileContent(workspacePath);
+                            isActive = workspaceContent === content;
+                        } catch (error) {
+                            this.logger.debug(`Failed to read workspace file for comparison: ${workspaceName}`);
+                            isActive = false;
+                        }
                     }
                 } catch (error) {
                     this.logger.debug(`Failed to check if prompt is active: ${workspaceName}`);
@@ -588,7 +593,7 @@ export class PromptTreeDataProvider implements vscode.TreeDataProvider<PromptTre
 
                         // If the file is in the prompts directory, check all repo storage for a matching file
                         if (normalizedFilePath.startsWith(normalizedPromptsDir)) {
-                            this.logger.debug(`Windows: Checking if ${fileName} is an active copy in prompts directory`);
+                            this.logger.debug(`Windows: File ${fileName} found in workspace prompts directory, checking against repository storage`);
                             // Note: This prompt is in the workspace directory
                             // It will be marked as active if we can find it in any repository storage
                             // The repository URL will remain undefined if not found