Skip to content

Commit 7fecc25

Browse files
[infra] Run C++ unit tests in PR USE_RERUN build job (#65)
The PR workflow previously only compiled USE_RERUN as a build smoke check, while nightly already runs tests for that configuration. Align PR coverage by pulling test_data, building for runner-compatible CUDA archs, and running ctest in the USE_RERUN job.
1 parent bc81d63 commit 7fecc25

1 file changed

Lines changed: 13 additions & 7 deletions

File tree

.github/workflows/pr-verify.yml

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -304,11 +304,11 @@ jobs:
304304
retention-days: 30
305305
if-no-files-found: warn
306306

307-
# Build-only smoke check for a non-default CMake configuration. Catches build/link
308-
# breakages the default (USE_RERUN=OFF) build never exercises. Build only: no tests,
309-
# wheels, docs, or evaluation (nightly runs the full USE_RERUN build+test).
307+
# Smoke check for a non-default CMake configuration. Catches build/link and test
308+
# breakages the default (USE_RERUN=OFF) build never exercises. Builds and runs the
309+
# C++ unit tests; no wheels, docs, or evaluation (nightly runs the full USE_RERUN build).
310310
build-rerun-x86:
311-
name: "Build (USE_RERUN, x86_64)"
311+
name: "Build + Test (USE_RERUN, x86_64)"
312312
if: github.event.pull_request.head.repo.full_name == github.repository
313313
runs-on: [gpu]
314314
timeout-minutes: 120
@@ -320,13 +320,19 @@ jobs:
320320
with:
321321
lfs: false
322322

323+
- name: Pull LFS test data
324+
run: git lfs pull --include="test_data/"
325+
323326
- name: Build with USE_RERUN
324327
env:
325-
# Pin one CUDA arch for speed: build-only, so the generated code need not
326-
# match the runner GPU.
327-
EXTRA_CMAKE_ARGS: "-DUSE_RERUN=ON -DCMAKE_CUDA_ARCHITECTURES=80"
328+
# Build for the default (all) CUDA archs so the generated kernels match the
329+
# runner GPU, which the C++ tests below require at runtime.
330+
EXTRA_CMAKE_ARGS: "-DUSE_RERUN=ON"
328331
run: ./scripts/build_cuvslam_in_docker.sh Release ./output-rerun
329332

333+
- name: Run C++ tests
334+
run: ./scripts/test_cuvslam_in_docker.sh ./output-rerun
335+
330336
test-report:
331337
name: "Post Test Report"
332338
if: always() && github.event.pull_request.head.repo.full_name == github.repository

0 commit comments

Comments
 (0)