[infra] Preserve nightly artifacts across reruns

[vikuznetsov-nvidia]

Defer aggregation and cleanup after matrix failures so selective job reruns can reuse successful jobs' staging artifacts.

Summary by CodeRabbit

• Bug Fixes
  • Improved nightly build reporting by preventing incomplete or failed build results from being consolidated as valid test and evaluation artifacts.
  • Staging artifacts are now deleted only after successful build-and-test completion.
  • Summary outputs now clearly indicate when no results could be consolidated.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: ef09c4e7-ad23-4cc2-9bf8-05e1cd9ee8fd

📥 Commits

Reviewing files that changed from the base of the PR and between d80b819 and 23d83c1.

📒 Files selected for processing (1)

• .github/workflows/nightly.yml

---

📝 Walkthrough

Walkthrough

The nightly workflow enables overwriting named artifacts and requires successful build-and-test completion before downloading, consolidating, or deleting staging artifacts. Failed builds defer consolidation and preserve staging artifacts.

Changes

Nightly artifact handling

Layer / File(s)	Summary
Enable artifact overwrites .github/workflows/nightly.yml	Build-and-test and nightly-summary uploads now use overwrite: true for named artifacts.
Gate summary processing and cleanup .github/workflows/nightly.yml	Artifact downloads and consolidation require a successful build-and-test matrix; staging cleanup runs only after success.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• nvidia-isaac/cuVSLAM#51: Modifies the same nightly workflow’s artifact consolidation and cleanup flow.

Suggested reviewers: hrabeti-nvidia, slepichev, hguillen

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main workflow change: preserving nightly artifacts across reruns by changing artifact handling.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch vikuznetsov/fix-nightly-rerun-artifacts

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Checkov (3.3.8)

.github/workflows/nightly.yml

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/nightly.yml:
- Line 577: Update the three upload-artifact steps in the nightly workflow to
ensure reruns replace existing staging artifacts, either by enabling overwrite:
true or by incorporating the workflow attempt into each artifact name. Preserve
the existing artifact grouping and consolidation behavior.
- Line 356: Replace every actions/download-artifact and actions/upload-artifact
tag reference in the nightly workflow, including the usages near the identified
download steps, with the approved immutable commit SHA for each action version;
keep the existing action inputs and workflow behavior unchanged.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 8c3d0678-53e0-46f1-981f-a15cd208bd1b

📥 Commits

Reviewing files that changed from the base of the PR and between f0019f6 and d80b819.

📒 Files selected for processing (1)

• .github/workflows/nightly.yml

[github-actions]

Test Results

Status	Platform	Language	Total	Passed	Failed	Errors	Skipped
✅	Orin	C++	16	16	0	0	0
✅	Orin	Python	68	67	0	0	1
✅	Thor	C++	16	16	0	0	0
✅	Thor	Python	68	67	0	0	1
✅	x86_64	C++	16	16	0	0	0
✅	x86_64	Python	68	67	0	0	1

cuVSLAM Evaluation KPIs

Config	Dataset	ATE,%	ARE,º/m	Kabsch,	Losts,	diff ATE,%	diff ARE,º/m	diff Kabsch,	diff Losts,	FPS,Hz
x86_64-cuda12.6.3-ubuntu24.04	KITTI-STEREO_ODOM	0.8367	0.0023	2.7928	0	NA	NA	NA	NA	303.0
x86_64-cuda12.6.3-ubuntu24.04	KITTI-STEREO_SLAM	0.7664	0.002	2.0402	0	NA	NA	NA	NA	186.4

Artifacts

• eval-html-report
• eval-kpis-pr
• test-results-x86_64
• docs-html
• test-results-orin
• test-results-thor