Skip to content

[infra] Enforce clean nightly version provenance#60

Open
vikuznetsov-nvidia wants to merge 1 commit into
mainfrom
vikuznetsov/nightly-version-provenance-workflow
Open

[infra] Enforce clean nightly version provenance#60
vikuznetsov-nvidia wants to merge 1 commit into
mainfrom
vikuznetsov/nightly-version-provenance-workflow

Conversation

@vikuznetsov-nvidia

@vikuznetsov-nvidia vikuznetsov-nvidia commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Keep the nightly checkout unchanged and reject wheels whose runtime version does not identify the checked-out commit.

Summary by CodeRabbit

  • Chores
    • Updated nightly Jetson builds for Orin and Thor configurations.
    • Improved ARM build and installation validation.
    • Enhanced Python wheel verification with package version and commit details.
    • Updated Ubuntu package mirror handling for container builds.

Keep the nightly checkout unchanged and reject wheels whose runtime version does not identify the checked-out commit.
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The nightly workflow adds Jetson ports-mirror parameters, passes mirror and clean-source settings into the C++ Docker build, removes Dockerfile patching, and supplies package version and commit information to Python wheel verification.

Changes

Nightly build and verification

Layer / File(s) Summary
Jetson mirror and clean-source build settings
.github/workflows/nightly.yml
Jetson Orin and Thor matrix entries define ports_mirror; the workflow removes inline Dockerfile mirror patching and passes UBUNTU_PORTS_MIRROR and CUVSLAM_REQUIRE_CLEAN_SOURCE=1 to the C++ build.
Wheel verification version wiring
.github/workflows/nightly.yml
Wheel verification receives PACKAGE_VERSION from the preflight output together with the current commit SHA.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: hrabeti-nvidia, slepichev, hguillen

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main goal of enforcing nightly version provenance and clean-source checks.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch vikuznetsov/nightly-version-provenance-workflow

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/nightly.yml (1)

118-118: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Restore the ARM64 apt mirror setup in the nightly Docker build. UBUNTU_PORTS_MIRROR is passed to scripts/build_cuvslam_in_docker.sh, but the script never forwards it into the container, so scripts/Dockerfile still uses the default ports.ubuntu.com sources and DEP-11 index targets. Jetson builds can still fail on unreachable apt endpoints.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/nightly.yml at line 118, Update the nightly Docker build
flow around build_cuvslam_in_docker.sh to forward UBUNTU_PORTS_MIRROR into the
container, and ensure scripts/Dockerfile uses that value for ARM64 apt sources
and DEP-11 index targets instead of defaulting to ports.ubuntu.com. Restore the
mirror setup while preserving existing behavior for other architectures.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In @.github/workflows/nightly.yml:
- Line 118: Update the nightly Docker build flow around
build_cuvslam_in_docker.sh to forward UBUNTU_PORTS_MIRROR into the container,
and ensure scripts/Dockerfile uses that value for ARM64 apt sources and DEP-11
index targets instead of defaulting to ports.ubuntu.com. Restore the mirror
setup while preserving existing behavior for other architectures.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 61a7c49a-08e0-457f-9df0-1aaa6b05c4b0

📥 Commits

Reviewing files that changed from the base of the PR and between b8c4992 and 45cea50.

📒 Files selected for processing (1)
  • .github/workflows/nightly.yml

@github-actions

Copy link
Copy Markdown

Test Results

Status Platform Language Total Passed Failed Errors Skipped
Orin C++ 16 16 0 0 0
Orin Python 68 67 0 0 1
Thor C++ 16 16 0 0 0
Thor Python 68 67 0 0 1
x86_64 C++ 16 16 0 0 0
x86_64 Python 68 67 0 0 1

cuVSLAM Evaluation KPIs

Config Dataset ATE,% ARE,º/m Kabsch, Losts, diff ATE,% diff ARE,º/m diff Kabsch, diff Losts, FPS,Hz
x86_64-cuda12.6.3-ubuntu24.04 KITTI-STEREO_ODOM 0.835 0.0023 2.6191 0 NA NA NA NA 303.9
x86_64-cuda12.6.3-ubuntu24.04 KITTI-STEREO_SLAM 0.7591 0.002 1.9562 0 NA NA NA NA 180.1

Artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant