[infra] Fail release preflight on existing target#62
Open
vikuznetsov-nvidia wants to merge 3 commits into
Open
[infra] Fail release preflight on existing target#62vikuznetsov-nvidia wants to merge 3 commits into
vikuznetsov-nvidia wants to merge 3 commits into
Conversation
Reject release dispatches with an existing draft, release, or tag before starting the expensive build matrix while retaining the final race check.
Avoid downloading release assets when a target created during the build has already made publication unavailable.
vikuznetsov-nvidia
requested review from
hrabeti-nvidia and
slepichev
as code owners
July 21, 2026 18:04
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe nightly workflow grants preflight read access and validates that the computed release target is unused before release processing and again after matrix jobs complete, before downloading release artifacts. ChangesRelease target validation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Test Results
cuVSLAM Evaluation KPIs
Artifacts |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/nightly.yml:
- Around line 103-105: Update both tag-existence probes in
.github/workflows/nightly.yml at lines 103-105 and 709-711 to distinguish a
successful 404 response from other gh api failures: continue only when the tag
is absent, reject existing tags, and fail the workflow for authentication,
rate-limit, network, or 5xx errors.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: a5136c96-3783-4352-93e4-36f925f188af
📒 Files selected for processing (1)
.github/workflows/nightly.yml
Query matching refs so absent tags return an empty successful result while authentication, network, and server failures stop publication.
hguillen
reviewed
Jul 21, 2026
| check-changes: | ||
| name: Check for recent changes | ||
| runs-on: ubuntu-latest | ||
| permissions: |
Collaborator
Author
There was a problem hiding this comment.
I put a check in front if release target exists, so that we don't run entire build for a release branch, only to fail it in the end, if it is already published
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject release dispatches with an existing draft, release, or tag before starting the expensive build matrix while retaining the final race check.
Summary by CodeRabbit