[infra] Stabilize libpng dependency download#63
Merged
Conversation
Fetch the unchanged libpng 1.6.55 tag from GitHub to avoid unreliable SourceForge mirror redirects.
vikuznetsov-nvidia
requested review from
hrabeti-nvidia and
slepichev
as code owners
July 21, 2026 21:07
📝 WalkthroughWalkthroughThe libpng CMake fetch configuration now downloads the versioned release tarball from GitHub instead of SourceForge and verifies it with an updated SHA256 hash. Changeslibpng Fetch Configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cmake/ext/libpng.cmake`:
- Around line 37-38: Update the LIBPNG_VERSION value to a release newer than
1.6.55, specifically at least 1.6.56, and replace the URL_HASH SHA256 with the
checksum for the selected release. Keep the archive URL interpolation unchanged
so the version and checksum remain synchronized.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 218f015e-27bd-4a9b-a36c-d560615cb8c4
📒 Files selected for processing (1)
cmake/ext/libpng.cmake
Test Results
cuVSLAM Evaluation KPIs
Artifacts |
slepichev
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetch the unchanged libpng 1.6.55 tag from GitHub to avoid unreliable SourceForge mirror redirects.
Summary by CodeRabbit