Skip to content

[infra] Stop blocking nightly builds on source check#67

Merged
vikuznetsov-nvidia merged 1 commit into
mainfrom
vikuznetsov/disable-nightly-clean-source-check
Jul 22, 2026
Merged

[infra] Stop blocking nightly builds on source check#67
vikuznetsov-nvidia merged 1 commit into
mainfrom
vikuznetsov/disable-nightly-clean-source-check

Conversation

@vikuznetsov-nvidia

@vikuznetsov-nvidia vikuznetsov-nvidia commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Allow builds to proceed when container-side Git checks cannot inspect the read-only checkout reliably.

Summary by CodeRabbit

  • Chores
    • Updated nightly build automation to streamline the C++ library build process.
    • Existing build steps and configuration remain unchanged.
    • No user-facing features or product behavior were modified.

Allow builds to proceed when container-side Git checks cannot inspect the read-only checkout reliably.
@vikuznetsov-nvidia
vikuznetsov-nvidia merged commit e9d9406 into main Jul 22, 2026
3 of 5 checks passed
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: f36f8b62-2d7a-474b-ad96-eab735012fb2

📥 Commits

Reviewing files that changed from the base of the PR and between 15847e9 and bee8ef6.

📒 Files selected for processing (1)
  • .github/workflows/nightly.yml

📝 Walkthrough

Walkthrough

The nightly C++ library build command no longer passes CUVSLAM_REQUIRE_CLEAN_SOURCE=1; subsequent build steps and CMake argument handling remain unchanged.

Changes

Nightly build workflow

Layer / File(s) Summary
Remove clean-source build variable
.github/workflows/nightly.yml
The Docker build command no longer includes CUVSLAM_REQUIRE_CLEAN_SOURCE=1; later build configuration remains unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • nvidia-isaac/cuVSLAM#60: Modifies the same nightly workflow variable wiring in the opposite direction by adding the variable.

Suggested reviewers: hrabeti-nvidia, slepichev

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch vikuznetsov/disable-nightly-clean-source-check

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Test Results

Status Platform Language Total Passed Failed Errors Skipped
Orin C++ 16 16 0 0 0
Orin Python 71 70 0 0 1
Thor C++ 16 16 0 0 0
Thor Python 71 70 0 0 1
⚠️ x86_64 C++ 0 0 0 0 0
⚠️ x86_64 Python 0 0 0 0 0

Artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant