[infra] Normalize Git state for nightly Docker builds#68
Conversation
Ignore runner-specific mode normalization and give Git LFS writable temporary storage when the checkout is mounted read-only.
Keep LFS materialization and read-only Docker mount configuration together in one workflow step.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe nightly workflow prepares Git and Git LFS before Docker builds by disabling file mode tracking, using writable temporary storage, and pulling ChangesNightly build preparation
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.3.8).github/workflows/nightly.ymlTraceback (most recent call last): Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/nightly.yml:
- Around line 118-123: Move the git config commands in the “Prepare Git checkout
for Docker build” step before git lfs pull, ensuring core.fileMode and
lfs.storage are configured before any LFS checkout writes occur.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 3fbf5b38-0223-489b-9a92-d3010fbd0a8e
📒 Files selected for processing (1)
.github/workflows/nightly.yml
Test Results
cuVSLAM Evaluation KPIs
Artifacts |
Apply runner mode and writable LFS storage settings before checkout materialization begins.
Ignore runner-specific mode normalization and give Git LFS writable temporary storage when the checkout is mounted read-only.
Summary by CodeRabbit