Skip to content

[infra] Normalize Git state for nightly Docker builds#68

Merged
vikuznetsov-nvidia merged 3 commits into
mainfrom
vikuznetsov/fix-nightly-read-only-git
Jul 22, 2026
Merged

[infra] Normalize Git state for nightly Docker builds#68
vikuznetsov-nvidia merged 3 commits into
mainfrom
vikuznetsov/fix-nightly-read-only-git

Conversation

@vikuznetsov-nvidia

@vikuznetsov-nvidia vikuznetsov-nvidia commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Ignore runner-specific mode normalization and give Git LFS writable temporary storage when the checkout is mounted read-only.

Summary by CodeRabbit

  • Chores
    • Improved the nightly Docker build workflow for more consistent Git and Git LFS behavior.
    • Adjusted Git and Git LFS settings to use a writable temporary LFS location during automated builds, enhancing reliability.

Ignore runner-specific mode normalization and give Git LFS writable temporary storage when the checkout is mounted read-only.
Keep LFS materialization and read-only Docker mount configuration together in one workflow step.
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: f8d099e5-dc1c-4ef0-8579-fc9cb065d77c

📥 Commits

Reviewing files that changed from the base of the PR and between c9cc26e and 7a28dac.

📒 Files selected for processing (1)
  • .github/workflows/nightly.yml

📝 Walkthrough

Walkthrough

The nightly workflow prepares Git and Git LFS before Docker builds by disabling file mode tracking, using writable temporary storage, and pulling test_data/.

Changes

Nightly build preparation

Layer / File(s) Summary
Prepare Git checkout for Docker build
.github/workflows/nightly.yml
The workflow configures Git and Git LFS, then pulls test_data/ for subsequent Docker build steps.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: hrabeti-nvidia, slepichev, hguillen

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main infra change: normalizing Git state for nightly Docker builds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch vikuznetsov/fix-nightly-read-only-git

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Checkov (3.3.8)
.github/workflows/nightly.yml

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'


Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/nightly.yml:
- Around line 118-123: Move the git config commands in the “Prepare Git checkout
for Docker build” step before git lfs pull, ensuring core.fileMode and
lfs.storage are configured before any LFS checkout writes occur.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 3fbf5b38-0223-489b-9a92-d3010fbd0a8e

📥 Commits

Reviewing files that changed from the base of the PR and between e9d9406 and c9cc26e.

📒 Files selected for processing (1)
  • .github/workflows/nightly.yml

Comment thread .github/workflows/nightly.yml
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

Test Results

Status Platform Language Total Passed Failed Errors Skipped
Orin C++ 16 16 0 0 0
Orin Python 71 70 0 0 1
Thor C++ 16 16 0 0 0
Thor Python 71 70 0 0 1
x86_64 C++ 16 16 0 0 0
x86_64 Python 71 70 0 0 1

cuVSLAM Evaluation KPIs

Config Dataset ATE,% ARE,º/m Kabsch, Losts, diff ATE,% diff ARE,º/m diff Kabsch, diff Losts, FPS,Hz
x86_64-cuda12.6.3-ubuntu24.04 KITTI-STEREO_ODOM 0.8439 0.0024 2.89 0 NA NA NA NA 300.9
x86_64-cuda12.6.3-ubuntu24.04 KITTI-STEREO_SLAM 0.7622 0.002 1.9426 0 NA NA NA NA 185.8

Artifacts

Apply runner mode and writable LFS storage settings before checkout materialization begins.
@vikuznetsov-nvidia
vikuznetsov-nvidia merged commit 57f42cc into main Jul 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant