FEATURE: When help window is open, do not completely close neotree when `q` is pressed

[rafamadriz]

Did you check the docs?

• I have read all the docs.

Is your feature request related to a problem? Please describe.

It is something really small but I found it extremely annoying, whenever I open the help window (?) to check something quick, I press q out of muscle memory to close that floating window, but it completely closes neotree and I have to open it again to continue with what I was doing.

q Is kinda like the standard key to close floating ui's (most other plugins and neotree itself use it for that purpose), but in this case I believe it makes sense to only close the help window when it is open and, not the entire neotree window.

I did look into the code to do a PR myself but got the impression that is not as simple as I initially thought (or maybe it is simple and I'm just stupid). Anyway if you think this makes sense and I get some indications, I'll be happy to do it.

Describe the solution you'd like.

Do not close the entire neotree window when q is pressed and the help window is open

Describe alternatives you've considered.

No response

Additional Context

No response

[pysan3]

Na, it's hardcoded to close with <ESC> so no luck...

neo-tree.nvim/lua/neo-tree/sources/common/help.lua

Lines 126 to 128 in cfe1920

	popup:map("n", "<esc>", function()
	popup:unmount()
	end, { noremap = true })

However, you can disable q from doing anything when help menu is on.
With this setting, you'll have to press <ESC> (to exit help) and then q to close neo-tree, which might be a better experience.

config = {
  window = {
    mappings = {
      ["?"] = { "show_help", config = { prefix_key = "q" } },
    },
  },
}

[pysan3]

Ref:

• feat: Uniform way of closing popup window #1361