refactor(agenda): optimize prefix formatting with pre-compilation and rename extra to marker for clarity

Author: swapnilsm

lua/orgmode/agenda/agenda_item.lua

@@ -21,7 +21,7 @@ end
 ---@field date_range_days number
 ---@field label string
 ---@field time string
----@field extra string
+---@field marker string
 ---@field index number
 local AgendaItem = {}
 
@@ -80,7 +80,7 @@ end
 
 function AgendaItem:_generate_data()
   self.time = self.headline_date:has_time() and self:_format_time(self.headline_date) or ''
-  self.extra = self:_generate_extra()
+  self.marker = self:_generate_marker()
   self.label = self:_generate_label()
 end
 
@@ -156,8 +156,8 @@ function AgendaItem:_is_valid_for_date()
 
   return false
 end
-
-function AgendaItem:_generate_extra()
+---@private
+function AgendaItem:_generate_marker()
   if self.headline_date:is_deadline() then
     if self.is_same_day then
       return 'Deadline:'
@@ -189,6 +189,7 @@ function AgendaItem:_generate_extra()
   return ''
 end
 
+
 function AgendaItem:_generate_label()
   local include_time = self.time ~= ''
   if (self.headline_date:is_deadline() or self.headline_date:is_scheduled()) and not self.is_same_day then
@@ -200,7 +201,7 @@ function AgendaItem:_generate_label()
   end
 
   local time = include_time and add_padding(self.time) or ''
-  return time .. self.extra
+  return time .. self.marker
 end
 
 ---@private

lua/orgmode/agenda/types/agenda.lua

@@ -249,6 +249,10 @@ function OrgAgendaType:render(bufnr, current_line)
   end
   local agenda_days = self:_get_agenda_days()
 
+  local prefix_formats = self.org_agenda_prefix_format or config.org_agenda_prefix_format
+  local prefix_format = prefix_formats.agenda
+  local compiled_prefix = Formatter.compile(prefix_format)
+
   local agendaView = AgendaView:new({ bufnr = self.bufnr, highlighter = self.highlighter })
   agendaView:add_line(AgendaLine:single_token({
     content = self:_get_title(),
@@ -272,7 +276,7 @@ function OrgAgendaType:render(bufnr, current_line)
     for _, agenda_item in ipairs(agenda_day.agenda_items) do
       -- If there is an index value, this is an AgendaItem instance
       if agenda_item.index then
-        agendaView:add_line(self:_build_line(agenda_item, agenda_day))
+        agendaView:add_line(self:_build_line(agenda_item, agenda_day, compiled_prefix))
       else
         agendaView:add_line(self:_build_time_grid_line(agenda_item, agenda_day))
       end
@@ -499,8 +503,9 @@ end
 ---@private
 ---@param agenda_item OrgAgendaItem
 ---@param metadata table<string, any>
+---@param compiled_prefix? OrgAgendaFormatterSegment[]
 ---@return OrgAgendaLine
-function OrgAgendaType:_build_line(agenda_item, metadata)
+function OrgAgendaType:_build_line(agenda_item, metadata, compiled_prefix)
   local headline = agenda_item.headline
   local item_hl_group = agenda_item:get_hlgroup()
   local line = AgendaLine:new({
@@ -515,7 +520,7 @@ function OrgAgendaType:_build_line(agenda_item, metadata)
   })
 
   local prefix_formats = self.org_agenda_prefix_format or config.org_agenda_prefix_format
-  local prefix_format = prefix_formats.agenda
+  local prefix_format = compiled_prefix or Formatter.compile(prefix_formats.agenda)
   local prefix = Formatter.format(prefix_format, agenda_item, metadata)
 
   line:add_token(AgendaLineToken:new({

lua/orgmode/agenda/types/todo.lua

@@ -111,6 +111,11 @@ end
 function OrgAgendaTodosType:render(bufnr)
   self.bufnr = bufnr or 0
   local headlines, category_length = self:_get_headlines()
+
+  local prefix_formats = self.org_agenda_prefix_format or config.org_agenda_prefix_format
+  local prefix_format = prefix_formats[self.prefix_key] or prefix_formats.todo
+  local compiled_prefix = Formatter.compile(prefix_format)
+
   local agendaView = AgendaView:new({ bufnr = self.bufnr, highlighter = self.highlighter })
 
   -- If custom view and no headlines, return empty view
@@ -132,7 +137,7 @@ function OrgAgendaTodosType:render(bufnr)
   end
 
   for _, headline in ipairs(headlines) do
-    agendaView:add_line(self:_build_line(headline, { category_length = category_length }))
+    agendaView:add_line(self:_build_line(headline, { category_length = category_length }, compiled_prefix))
   end
 
   self.view = agendaView:render()
@@ -142,16 +147,17 @@ end
 ---@private
 ---@param headline OrgHeadline
 ---@param metadata table<string, any>
+---@param compiled_prefix? OrgAgendaFormatterSegment[]
 ---@return OrgAgendaLine
-function OrgAgendaTodosType:_build_line(headline, metadata)
+function OrgAgendaTodosType:_build_line(headline, metadata, compiled_prefix)
   local line = AgendaLine:new({
     headline = headline,
     line_hl_group = headline:is_clocked_in() and 'Visual' or nil,
     metadata = metadata,
   })
 
   local prefix_formats = self.org_agenda_prefix_format or config.org_agenda_prefix_format
-  local prefix_format = prefix_formats[self.prefix_key] or prefix_formats.todo
+  local prefix_format = compiled_prefix or Formatter.compile(prefix_formats[self.prefix_key] or prefix_formats.todo)
   local prefix = Formatter.format(prefix_format, nil, metadata, headline)
 
   line:add_token(AgendaLineToken:new({