Adding the show_symlink option to finder#334
Open
aadi58002 wants to merge 1 commit intonvim-telescope:masterfrom
Open
Adding the show_symlink option to finder#334aadi58002 wants to merge 1 commit intonvim-telescope:masterfrom
aadi58002 wants to merge 1 commit intonvim-telescope:masterfrom
Conversation
jamestrew
requested changes
Nov 26, 2023
Collaborator
jamestrew
left a comment
There was a problem hiding this comment.
I think we're on the right track.
Besides the changes I mentioned, we also need to tackle the <cr> behavior when show_symlinks = true and follow_symlinks = false.
Right now, the open_dir action already calls fs_realpath so it follows symlinks regardless of the follow_symlinks option. I think this can be considered a bug.
Probably want to take that out. We can dictate which path (real or symlink) <cr> will act on here:
follow_symlinks = true or keep it t.value.
Also CI is failing. I think you just need to run stylua.
|
this really should be merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the issue #300
And also the reopen issue for #323 ( which was closed by mistake )