Skip to content

Adding the show_symlink option to finder#334

Open
aadi58002 wants to merge 1 commit intonvim-telescope:masterfrom
aadi58002:personal
Open

Adding the show_symlink option to finder#334
aadi58002 wants to merge 1 commit intonvim-telescope:masterfrom
aadi58002:personal

Conversation

@aadi58002
Copy link
Copy Markdown

Addresses the issue #300

And also the reopen issue for #323 ( which was closed by mistake )

Copy link
Copy Markdown
Collaborator

@jamestrew jamestrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're on the right track.
Besides the changes I mentioned, we also need to tackle the <cr> behavior when show_symlinks = true and follow_symlinks = false.

Right now, the open_dir action already calls fs_realpath so it follows symlinks regardless of the follow_symlinks option. I think this can be considered a bug.
Probably want to take that out. We can dictate which path (real or symlink) <cr> will act on here:

if k == "path" then
return t.value
end
by setting this to realpath if follow_symlinks = true or keep it t.value.

Also CI is failing. I think you just need to run stylua.

Comment thread doc/telescope-file-browser.txt
Comment thread lua/telescope/_extensions/file_browser/make_entry.lua Outdated
Comment thread lua/telescope/_extensions/file_browser/make_entry.lua Outdated
Comment thread lua/telescope/_extensions/file_browser/make_entry.lua Outdated
@gmankab
Copy link
Copy Markdown

gmankab commented Oct 22, 2024

this really should be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants