Fix file-browser resize errors when no entry is selected#429
Open
RedTrait wants to merge 1 commit into
Open
Conversation
Prevent telescope-file-browser from throwing an error during VimResized autocommands when the picker has no active selection. The resize callback assumed action_state.get_selected_entry() always returned a valid entry and accessed selection.value unconditionally. In practice, the picker can briefly have no selected entry while being refreshed or closed, which causes a Lua error. This change adds guards for: - missing picker state - missing selected entry - missing selected entry value When a valid selection exists, the previous selection is restored as before and the picker is refreshed normally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent telescope-file-browser from throwing an error during VimResized autocommands when the picker has no active selection.
The resize callback assumed action_state.get_selected_entry() always returned a valid entry and accessed selection.value unconditionally. In practice, the picker can briefly have no selected entry while being refreshed or closed, which causes a Lua error.
This change adds guards for:
When a valid selection exists, the previous selection is restored as before and the picker is refreshed normally.