Make config universal#168
Open
myarcana wants to merge 4 commits intonvim-telescope:masterfrom
Open
Conversation
Collaborator
|
Sorry @myarcana I missed this one, and now there are conflicts. If you're able to resolve the conflicts - run it locally without issues, I will re-review and merge. Thanks |
|
I have created a fork to apply this patch and i'm using it since them. By the weekend I can pull the latest updates, fix any conflict and open a new PR if you don't mind. :) |
Collaborator
That would be great! Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had
In my vimrc for the longest time without noticing my settings weren't having any effects.
In taking a look at @akkaargh's comment in #165, I noticed that there were two types of settings for this plugin: picker-time settings and setup-time settings.
Actually, it seems like all options make sense to be able to apply both at setup time and at picker-open time, so I've merged them.
After this PR, my config will start to work as I had originally expected it to.