Skip to content

fix: vim.deprecation of vim.F by providing a stub for now#3663

Merged
clason merged 1 commit into
nvim-telescope:masterfrom
Conni2461:fix/if_nil
May 14, 2026
Merged

fix: vim.deprecation of vim.F by providing a stub for now#3663
clason merged 1 commit into
nvim-telescope:masterfrom
Conni2461:fix/if_nil

Conversation

@Conni2461
Copy link
Copy Markdown
Member

No description provided.

@Conni2461 Conni2461 requested a review from clason May 6, 2026 14:10
Comment thread lua/telescope/utils.lua Outdated
@Conni2461
Copy link
Copy Markdown
Member Author

do we need a ci/lint check? to ensure that vim.F is no longer used?

@clason
Copy link
Copy Markdown
Contributor

clason commented May 6, 2026

No, vim.F is still there... A check to prevent regressions would be useful but requires Neovim to provide deprecations in a structured way.

@clason
Copy link
Copy Markdown
Contributor

clason commented May 6, 2026

@delphinus frecency has (or will have) a similar issue with vim.F.npcall.

@Conni2461
Copy link
Copy Markdown
Member Author

okay then the deprecated functions, new features/fixes coming from PRs should not contain usages of vim.F.if_nil or vim.F.npcall and that could be overlooked. i hoped that luacheck has something for that, but it doesnt seem like that.

@clason
Copy link
Copy Markdown
Contributor

clason commented May 6, 2026

Luals does report Deprecated as a warning, but will do so even if used like this... (And we can't use that with the current annotations...)

(You won't see it on CI until the nightly is updated tomorrow with the merged patch.)

@delphinus
Copy link
Copy Markdown
Member

Oh, I haven't noticed the deprecation of vim.F. I will fix for that.

@Conni2461
Copy link
Copy Markdown
Member Author

i would still patch plenary tbh, we said that its still supported this quarter

@clason
Copy link
Copy Markdown
Contributor

clason commented May 6, 2026

related fzf-native fix: nvim-telescope/telescope-fzf-native.nvim#159

@clason
Copy link
Copy Markdown
Contributor

clason commented May 6, 2026

i would still patch plenary tbh, we said that its still supported this quarter

Yeah, but the current deprecation warning will be dropped for now (removal moved to Nvim 0.15), so it's not really necessary. (But of course can still be done; just trying to save you some effort!)

@clason
Copy link
Copy Markdown
Contributor

clason commented May 6, 2026

Fixup is merged, warning is gone (for 0.12, so this change is still valuable) :)

@clason clason merged commit aa4ad82 into nvim-telescope:master May 14, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants