chore: add should_expand in DirectoryNode to avoid circular dependecy

Author: Uanela

lua/nvim-tree/node/directory.lua

@@ -327,6 +327,28 @@ function DirectoryNode:descend_until_empty()
   return not should_exclude
 end
 
+---@param expansion_count integer
+---@param should_descend fun(expansion_count: integer, node: Node): boolean
+---@return boolean
+function DirectoryNode:should_expand(expansion_count, should_descend)
+  if not self.open and should_descend(expansion_count, self) then
+    if #self.nodes == 0 then
+      self.explorer:expand_dir_node(self) -- populate node.group_next
+    end
+
+    if self.group_next then
+      local expand_next = self.group_next:should_expand(expansion_count, should_descend)
+      if expand_next then
+        self.open = true
+      end
+      return expand_next
+    else
+      return true
+    end
+  end
+  return false
+end
+
 ---@param expand_opts ApiTreeExpandOpts?
 function DirectoryNode:expand(expand_opts)
   local expansion_count = 0

lua/nvim-tree/node/init.lua

@@ -148,28 +148,6 @@ end
 ---@param should_descend fun(expansion_count: integer, node: Node): boolean
 ---@return boolean
 function Node:should_expand(expansion_count, should_descend)
-  local DirectoryNode = require("nvim-tree.node.directory")
-
-  local dir = self:as(DirectoryNode)
-  if not dir then
-    return false
-  end
-
-  if not dir.open and should_descend(expansion_count, self) then
-    if #self.nodes == 0 then
-      self.explorer:expand_dir_node(dir) -- populate node.group_next
-    end
-
-    if dir.group_next then
-      local expand_next = dir.group_next:should_expand(expansion_count, should_descend)
-      if expand_next then
-        dir.open = true
-      end
-      return expand_next
-    else
-      return true
-    end
-  end
   return false
 end