perf(#3257): remove system-open setup

Author: alex-courtis

lua/nvim-tree/actions/init.lua

@@ -6,7 +6,6 @@ M.node = require("nvim-tree.actions.node")
 M.tree = require("nvim-tree.actions.tree")
 
 function M.setup(opts)
-  M.node.setup(opts)
   M.tree.setup(opts)
 end
 

lua/nvim-tree/actions/node/init.lua

@@ -6,8 +6,4 @@ M.run_command = require("nvim-tree.actions.node.run-command")
 M.system_open = require("nvim-tree.actions.node.system-open")
 M.buffer = require("nvim-tree.actions.node.buffer")
 
-function M.setup(opts)
-  require("nvim-tree.actions.node.system-open").setup(opts)
-end
-
 return M

lua/nvim-tree/actions/node/system-open.lua

@@ -1,18 +1,33 @@
 local notify = require("nvim-tree.notify")
 local utils = require("nvim-tree.utils")
+local config = require("nvim-tree.config")
 
 local M = {}
 
 ---@param node Node
 local function user(node)
-  if #M.config.system_open.cmd == 0 then
-    require("nvim-tree.utils").notify.warn("Cannot open file with system application. Unrecognized platform.")
+  local cmd = config.g.system_open.cmd
+  local args = config.g.system_open.args
+
+  if #cmd == 0 then
+    if utils.is_windows then
+      cmd = "cmd"
+      args = { "/c", "start", '""' }
+    elseif utils.is_macos then
+      cmd = "open"
+    elseif utils.is_unix then
+      cmd = "xdg-open"
+    end
+  end
+
+  if #cmd == 0 then
+    notify.warn("Cannot open file with system application. Unrecognized platform.")
     return
   end
 
   local process = {
-    cmd = M.config.system_open.cmd,
-    args = M.config.system_open.args,
+    cmd = cmd,
+    args = args,
     errors = "\n",
     stderr = vim.loop.new_pipe(false),
   }
@@ -61,30 +76,11 @@ end
 
 ---@param node Node
 function M.fn(node)
-  M.open(node)
-end
-
--- TODO #2430 always use native once 0.10 is the minimum neovim version
-function M.setup(opts)
-  M.config = {}
-  M.config.system_open = opts.system_open or {}
-
-  if vim.fn.has("nvim-0.10") == 1 and #M.config.system_open.cmd == 0 then
-    M.open = native
+  -- TODO #2430 always use native once 0.10 is the minimum neovim version
+  if vim.fn.has("nvim-0.19") == 1 and #config.g.system_open.cmd == 0 then
+    native(node)
   else
-    M.open = user
-    if #M.config.system_open.cmd == 0 then
-      if utils.is_windows then
-        M.config.system_open = {
-          cmd = "cmd",
-          args = { "/c", "start", '""' },
-        }
-      elseif utils.is_macos then
-        M.config.system_open.cmd = "open"
-      elseif utils.is_unix then
-        M.config.system_open.cmd = "xdg-open"
-      end
-    end
+    user(node)
   end
 end
 

lua/nvim-tree/config.lua

@@ -303,14 +303,6 @@ M.d = { -- config-default-start
   },
 } -- config-default-end
 
--- Immediately apply OS specific localisations to defaults
-if utils.is_macos or utils.is_windows then
-  M.d.trash.cmd = "trash"
-end
-if utils.is_windows then
-  M.d.filesystem_watchers.max_events = 1000
-end
-
 local FIELD_SKIP_VALIDATE = {
   open_win_config = true,
 }
@@ -486,11 +478,24 @@ local function validate_config(u)
   end
 end
 
+---Localise the (default) config with OS specifics
+---@param d nvim_tree.config
+local function localise_config(d)
+  -- Trash
+  if utils.is_macos or utils.is_windows then
+    d.trash.cmd = "trash"
+  end
+
+  -- Watchers
+  if utils.is_windows then
+    d.filesystem_watchers.max_events = 1000
+  end
+end
+
 ---Normalise the (user) config
 ---@param u nvim_tree.config
 local function process_config(u)
-
-  ---Always use upper case for window pickers
+  -- Open
   if u.actions.open_file.window_picker.chars then
     u.actions.open_file.window_picker.chars = tostring(u.actions.open_file.window_picker.chars):upper()
   end
@@ -541,4 +546,7 @@ function M.g_clone()
   return vim.deepcopy(M.g)
 end
 
+---Immediately localise the defaults once and once only
+localise_config(M.d)
+
 return M