Merge branch 'master' into chore-sed-bsd-compatibility

Author: alex-courtis

CONTRIBUTING.md

@@ -27,6 +27,10 @@ markdown-toc --maxdepth=2 -i CONTRIBUTING.md
 - [Windows](#windows)
 - [Pull Request](#pull-request)
   * [Subject](#subject)
+- [AI Usage Policy: Highly Discouraged](#ai-usage-policy-highly-discouraged)
+  * [nvim-tree Is A Community Project](#nvim-tree-is-a-community-project)
+  * [The Burden Of Review Must Not Increase](#the-burden-of-review-must-not-increase)
+  * [AI Generated PR Rules](#ai-generated-pr-rules)
 
 <!-- tocstop -->
 
@@ -38,7 +42,7 @@ Language server: [luals](https://luals.github.io)
 
 Lint: [luacheck](https://github.com/lunarmodules/luacheck/)
 
-nvim-tree.lua migrated from stylua to EmmyLuaCodeStyle ~2024/10. `vim.lsp.buf.format()` may be used as it is the default formatter for luals, using an embedded [EmmyLuaCodeStyle](https://github.com/CppCXY/EmmyLuaCodeStyle)
+nvim-tree migrated from stylua to EmmyLuaCodeStyle ~2024/10. `vim.lsp.buf.format()` may be used as it is the default formatter for luals, using an embedded [EmmyLuaCodeStyle](https://github.com/CppCXY/EmmyLuaCodeStyle)
 
 Formatting: [EmmyLuaCodeStyle](https://github.com/CppCXY/EmmyLuaCodeStyle): `CodeFormat` executable
 
@@ -232,3 +236,45 @@ Available types:
 If in doubt, look at previous commits.
 
 See also [The Conventional Commits ultimate cheatsheet](https://gist.github.com/gabrielecanepa/fa6cca1a8ae96f77896fe70ddee65527)
+
+# AI Usage Policy: Highly Discouraged
+
+## nvim-tree Is A Community Project
+
+nvim-tree is a work of passion, building a community of free thinking individuals who contribute highly polished, elegant and maintainable code. Community members range from novices to professionals and all are welcome. Teaching, encouraging and celebrating the growth of less experienced developers is of great importance.
+
+AI generated code is discouraged as this doesn't match these nvim-tree values.
+
+Human PR reviews will always be prioritised over AI generated PRs.
+
+## The Burden Of Review Must Not Increase
+
+There must be a human in the loop at all times. The contributor is the author of and is fully accountable for AI generated contributions.
+
+AI generated PRs have low, or even non-existent entry level. Human generated PRs require you to be motivated, do research, familiarise yourself with code, make effort to write the code and test it.
+
+Low effort or unqualified code increases the burden of review and testing on maintainers, who are limited in time.
+
+Contributors must:
+
+- Read and review all generated code and documentation before raising a PR
+- Fully understand all code and documentation
+- Be able to answer any questions during review
+
+## AI Generated PR Rules
+
+The PR description and comments must be written by the contributor, with no AI assistance beyond grammar or English translations.
+
+The description must:
+
+- Describe the solution design, justifying all decisions
+- Clearly state which AI was used
+- List which code and documentation was written by a human and which was written by AI
+- Detail all testing performed
+
+There must be far greater than usual number of detailed, explicit comments:
+
+- File level: overview of the changes made
+- Line level: 1-2 comments per function/method
+
+Do not enable or use any AI review tools (e.g. Copilot) on the Pull Request.

doc/nvim-tree-lua.txt

@@ -1709,9 +1709,11 @@ Config: filesystem_watchers             *nvim-tree-config-filesystem-watchers*
                            between filesystem change and tree update.
       • {ignore_dirs}?     (`string[]|(fun(path: string): boolean)`, default: `{ "/.ccls-cache", "/build", "/node_modules", "/target", "/.zig-cache"}`)
                            Disable for specific directories.
-      • {max_events}?      (`integer`, default: `1000`) Disable for a single
-                           directory after {max_events} consecutive events
-                           with an interval < {debounce_delay}.
+      • {max_events}?      (`integer`, default: `0` or `1000` on windows)
+                           Disable for a single directory after {max_events}
+                           consecutive events with an interval <
+                           {debounce_delay}. Set to 0 to allow unlimited
+                           consecutive events.
 
 
 
@@ -2182,7 +2184,7 @@ Following is the default configuration, see |nvim_tree.config| for details. >lua
       filesystem_watchers = {
         enable = true,
         debounce_delay = 50,
-        max_events = 1000,
+        max_events = 0,
         ignore_dirs = {
           "/.ccls-cache",
           "/build",

lua/nvim-tree.lua

@@ -463,7 +463,7 @@ local DEFAULT_OPTS = { -- default-config-start
   filesystem_watchers = {
     enable = true,
     debounce_delay = 50,
-    max_events = 1000,
+    max_events = 0,
     ignore_dirs = {
       "/.ccls-cache",
       "/build",
@@ -738,6 +738,9 @@ local function localise_default_opts()
   if utils.is_macos or utils.is_windows then
     DEFAULT_OPTS.trash.cmd = "trash"
   end
+  if utils.is_windows then
+    DEFAULT_OPTS.filesystem_watchers.max_events = 1000
+  end
 end
 
 function M.purge_all_state()

lua/nvim-tree/_meta/config/filesystem_watchers.lua

@@ -31,5 +31,6 @@ error("Cannot require a meta file")
 ---@field ignore_dirs? string[]|(fun(path: string): boolean)
 ---
 ---Disable for a single directory after {max_events} consecutive events with an interval < {debounce_delay}.
----(default: `1000`)
+---Set to 0 to allow unlimited consecutive events.
+---(default: `0` or `1000` on windows)
 ---@field max_events? integer

lua/nvim-tree/explorer/watch.lua

@@ -79,12 +79,12 @@ function M.create_watcher(node)
     watcher.data.outstanding_events = watcher.data.outstanding_events + 1
 
     -- disable watcher when outstanding exceeds max
-    if watcher.data.outstanding_events > M.config.filesystem_watchers.max_events then
+    if M.config.filesystem_watchers.max_events > 0 and watcher.data.outstanding_events > M.config.filesystem_watchers.max_events then
       notify.error(string.format(
         "Observed %d consecutive file system events with interval < %dms, exceeding filesystem_watchers.max_events=%s. Disabling watcher for directory '%s'. Consider adding this directory to filesystem_watchers.ignore_dirs",
         watcher.data.outstanding_events,
-        M.config.filesystem_watchers.max_events,
         M.config.filesystem_watchers.debounce_delay,
+        M.config.filesystem_watchers.max_events,
         node.absolute_path
       ))
       node:destroy_watcher()

lua/nvim-tree/git/utils.lua

@@ -11,7 +11,7 @@ local M = {
 ---@return integer exit code
 local function system(cmd)
   if vim.fn.has("nvim-0.10") == 1 then
-    local obj = vim.system(cmd):wait()
+    local obj = vim.system(cmd):wait(M.opts.git.timeout)
     return obj.stdout or "", obj.code
   else
     return vim.fn.system(cmd), vim.v.shell_error
@@ -199,6 +199,7 @@ function M.setup(opts)
   if opts.git.cygwin_support then
     M.use_cygpath = vim.fn.executable("cygpath") == 1
   end
+  M.opts = opts
 end
 
 return M