perf(#3257): remove appearance and log setup

Author: alex-courtis

lua/nvim-tree.lua

@@ -281,14 +281,14 @@ function M.setup(config_user)
 
   manage_netrw()
 
-  require("nvim-tree.log").setup(config.g)
+  require("nvim-tree.log").start()
 
   if log.enabled("config") then
     log.line("config", "default config + user")
     log.raw("config", "%s\n", vim.inspect(config.g))
   end
 
-  require("nvim-tree.appearance").setup()
+  require("nvim-tree.appearance").define_hi()
 
   require("nvim-tree.view-state").initialize()
 

lua/nvim-tree/appearance/init.lua

@@ -182,7 +182,8 @@ M.LEGACY_LINKS = {
   NvimTreeDiagnosticHintFolderHL = "NvimTreeLspDiagnosticsHintFolderText",
 }
 
-function M.setup()
+---Create all highlight groups and links. Idempotent.
+function M.define_hi()
   -- non-linked
   for _, g in ipairs(M.HIGHLIGHT_GROUPS) do
     if g.def then

lua/nvim-tree/explorer/init.lua

@@ -88,7 +88,7 @@ function Explorer:create_autocmds()
   vim.api.nvim_create_autocmd("ColorScheme", {
     group = self.augroup_id,
     callback = function()
-      appearance.setup()
+      appearance.define_hi()
       view.reset_winhl()
       self.renderer:draw()
     end,

lua/nvim-tree/log.lua

@@ -1,3 +1,5 @@
+local config = require("nvim-tree.config")
+
 ---@alias LogTypes "all" | "config" | "copy_paste" | "dev" | "diagnostics" | "git" | "profile" | "watcher"
 
 ---@type table<LogTypes, boolean>
@@ -110,11 +112,12 @@ function M.enabled(typ)
   return file_path ~= nil and (types[typ] or types.all)
 end
 
-function M.setup(opts)
-  if opts.log and opts.log.enable and opts.log.types then
-    types = opts.log.types
+--- Create the log file and enable logging, if globally configured
+function M.start()
+  if config.g.log and config.g.log.enable and config.g.log.types then
+    types = config.g.log.types
     file_path = string.format("%s/nvim-tree.log", vim.fn.stdpath("log"), os.date("%H:%M:%S"), vim.env.USER)
-    if opts.log.truncate then
+    if config.g.log.truncate then
       os.remove(file_path)
     end
     require("nvim-tree.notify").debug("nvim-tree.lua logging to " .. file_path)