refactor(#3255): wire node.navigate.parent API impl directly to functions

Author: alex-courtis

lua/nvim-tree/actions/moves/parent.lua

@@ -3,40 +3,45 @@ local DirectoryNode = require("nvim-tree.node.directory")
 
 local M = {}
 
----@param should_close boolean|nil
----@return fun(node: Node): boolean|nil
-function M.fn(should_close)
-  should_close = should_close or false
-
-  ---@param node Node
-  return function(node)
-    local dir = node:as(DirectoryNode)
-    if dir then
-      dir = dir:last_group_node()
-      if should_close and dir.open then
-        dir.open = false
-        dir.explorer.renderer:draw()
-        return
-      end
+---@param node Node
+---@param should_close boolean
+local function move(node, should_close)
+  local dir = node:as(DirectoryNode)
+  if dir then
+    dir = dir:last_group_node()
+    if should_close and dir.open then
+      dir.open = false
+      dir.explorer.renderer:draw()
+      return
     end
+  end
 
-    local parent = (node:get_parent_of_group() or node).parent
+  local parent = (node:get_parent_of_group() or node).parent
 
-    if not parent or not parent.parent then
-      view.set_cursor({ 1, 0 })
-      return
-    end
+  if not parent or not parent.parent then
+    view.set_cursor({ 1, 0 })
+    return
+  end
 
-    local _, line = parent.explorer:find_node(function(n)
-      return n.absolute_path == parent.absolute_path
-    end)
+  local _, line = parent.explorer:find_node(function(n)
+    return n.absolute_path == parent.absolute_path
+  end)
 
-    view.set_cursor({ line + 1, 0 })
-    if should_close then
-      parent.open = false
-      parent.explorer.renderer:draw()
-    end
+  view.set_cursor({ line + 1, 0 })
+  if should_close then
+    parent.open = false
+    parent.explorer.renderer:draw()
   end
 end
 
+---@param node Node
+function M.move(node)
+  move(node, false)
+end
+
+---@param node Node
+function M.move_close(node)
+  move(node, true)
+end
+
 return M

lua/nvim-tree/api/impl/post.lua

@@ -211,8 +211,8 @@ function M.hydrate(api)
   api.node.navigate.sibling.prev = wrap_node(actions.moves.sibling.prev)
   api.node.navigate.sibling.first = wrap_node(actions.moves.sibling.first)
   api.node.navigate.sibling.last = wrap_node(actions.moves.sibling.last)
-  api.node.navigate.parent = wrap_node(actions.moves.parent.fn(false))
-  api.node.navigate.parent_close = wrap_node(actions.moves.parent.fn(true))
+  api.node.navigate.parent = wrap_node(actions.moves.parent.move)
+  api.node.navigate.parent_close = wrap_node(actions.moves.parent.move_close)
   api.node.navigate.git.next = wrap_node(actions.moves.item.fn({ where = "next", what = "git" }))
   api.node.navigate.git.next_skip_gitignored = wrap_node(actions.moves.item.fn({ where = "next", what = "git", skip_gitignored = true }))
   api.node.navigate.git.next_recursive = wrap_node(actions.moves.item.fn({ where = "next", what = "git", recurse = true }))