fix(#3117): allow changing filename's casing#3118
fix(#3117): allow changing filename's casing#3118ktnlvr wants to merge 0 commit intonvim-tree:masterfrom
Conversation
alex-courtis
left a comment
alex-courtis
left a comment
There was a problem hiding this comment.
I've tested the new code on linux and it executes as per the existing, for what that's worth.
- Have you tested on powershell?
It's not worth checking errors from the fs_ functions; we cannot reasonably action any problems, matching existing code. Checkting nil returns is sufficient.
As this is behind a feature flag, I'm happy to merge it. If there are any issues we'll revert it and call on you to make a fix, as we lack the OS and knowledge to do so.
alex-courtis
left a comment
alex-courtis
left a comment
There was a problem hiding this comment.
I've tested the new code on linux and it executes as per the existing, for what that's worth.
- Have you tested on powershell?
- Are there any other test cases e.g. command.com?
It's not worth checking errors from the fs_ functions; we cannot reasonably action any problems, matching existing code. Checkting nil returns is sufficient.
As this is behind a feature flag, I'm happy to merge it. If there are any issues we'll revert it and call on you to make a fix, as we lack the OS and knowledge to do so.
|
Good call, breaks on Windows. Will look into it and fix. |
ktnlvr
force-pushed
the
master
branch
2 times, most recently
from
ec494af to
6503bd2
Compare
alex-courtis
left a comment
alex-courtis
left a comment
There was a problem hiding this comment.
Looks good, feature flag is in place and you have tested the windows variants.
Code style is failing; take a look at https://github.com/nvim-tree/nvim-tree.lua/blob/master/CONTRIBUTING.md#style
| -- implementation of checking for existance is needed. | ||
| -- Same holds for WSL, since it can sometimes | ||
| -- access Windows files directly. | ||
| -- For more details see (#3117). |
|
Well that's interesting. Didn't know GitHub automagically closes the PR if the remote history is overwritten, the fixes to the Windows/Powershell issue are now gone. I'll fix it again in a moment. |
Perhaps that's a "feature" for pull requests from a fork. I'll add you as a member so that you can push a branch for future PRs. |
2 participants
Closes (#3117). Seems a little crude, but I don't think there is an easier way.