Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
c1948cb
feat: Allow to expand nodes until certain condition is met
ghostbuster91 Jul 20, 2025
641f125
Fix warnings
ghostbuster91 Jul 20, 2025
114fde0
Merge branch 'master' into expand-until-2
alex-courtis Jul 27, 2025
72404b9
Restore original position of edit function
ghostbuster91 Aug 2, 2025
06575bc
Rename field to match the api method name
ghostbuster91 Aug 2, 2025
8936460
Rename ApiTreeExpandAllOpts to ApiTreeExpandOpts
ghostbuster91 Aug 2, 2025
e3c3105
Merge branch 'master' into expand-until-2
ghostbuster91 Aug 2, 2025
71271e3
Remove toggle_descend_until
ghostbuster91 Aug 2, 2025
03e3a15
Remove redundant empty line
ghostbuster91 Aug 2, 2025
4ab16dd
Update :help for changed methods
ghostbuster91 Aug 2, 2025
3dac0be
Fix partial expansion of grouped nodes
ghostbuster91 Aug 2, 2025
160ae4f
Fix lint error
ghostbuster91 Aug 2, 2025
37b3516
Fix linting error
ghostbuster91 Aug 2, 2025
587068c
Merge branch 'master' into expand-until-2
ghostbuster91 Aug 10, 2025
eabd08c
Fix incorrect open/close indicator state
ghostbuster91 Aug 10, 2025
669a79f
Update docs
ghostbuster91 Aug 10, 2025
8425ef0
Rename descend_until option to expand_until
ghostbuster91 Aug 10, 2025
c4777ab
Always check directory expansion limit
ghostbuster91 Aug 10, 2025
cc25680
Fix linter errors
ghostbuster91 Aug 10, 2025
ba2d11f
Ignore unused param warning
ghostbuster91 Aug 10, 2025
8ecfcd0
Apply suggestions from code review
alex-courtis Aug 11, 2025
8c42c02
simplify MAX_FOLDER_DISCOVERY warning
alex-courtis Aug 11, 2025
3c666c4
fix bad comment whitespace
alex-courtis Aug 11, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 45 additions & 12 deletions lua/nvim-tree/actions/tree/modifiers/expand.lua
Original file line number Diff line number Diff line change
Expand Up @@ -30,17 +30,35 @@ end
---@param expansion_count integer
Comment thread
alex-courtis marked this conversation as resolved.
Outdated
---@param node Node
---@return boolean
local function should_expand(expansion_count, node)
local function descend_until_max_or_empty(expansion_count, node)
local dir = node:as(DirectoryNode)
if not dir then
return false
end

local should_halt = expansion_count >= M.MAX_FOLDER_DISCOVERY
local should_exclude = M.EXCLUDE[dir.name]
return not should_halt and not dir.open and not should_exclude

return not should_halt and not should_exclude
end

---@param expansion_count integer
---@param node Node
---@param should_descend fun(expansion_count: integer, node: Node): boolean
---@return boolean
local function should_expand(expansion_count, node, should_descend)
local dir = node:as(DirectoryNode)
if not dir then
return false
end

return not dir.open and should_descend(expansion_count, node)
end

local function gen_iterator()

---@param should_descend fun(expansion_count: integer, node: Node): boolean
---@return fun(node): any
local function gen_iterator(should_descend)
local expansion_count = 0

return function(parent)
Expand All @@ -52,7 +70,7 @@ local function gen_iterator()
Iterator.builder(parent.nodes)
:hidden()
:applier(function(node)
if should_expand(expansion_count, node) then
if should_expand(expansion_count, node, should_descend) then
expansion_count = expansion_count + 1
node = node:as(DirectoryNode)
if node then
Expand All @@ -61,7 +79,19 @@ local function gen_iterator()
end
end)
:recursor(function(node)
return expansion_count < M.MAX_FOLDER_DISCOVERY and (node.group_next and { node.group_next } or (node.open and node.nodes))
if not should_descend(expansion_count, node) then
return nil
end

if node.group_next then
return { node.group_next }
end

if node.open and node.nodes then
return node.nodes
end

return nil
end)
:iterate()

Expand All @@ -72,12 +102,13 @@ local function gen_iterator()
end

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The max folder discovery test above does not appear to be necessary as limit_folder_discovery does the job.

Commenting this out results in the correct number of folders being expanded, just no message.

Having the same test twice in two locations is fragile and unclear.

Proposal: limit_folder_discovery prints the warning and gen_iterator's function returns nothing.


---@param node Node?
local function expand_node(node)
---@param expand_opts ApiTreeExpandAllOpts?
Comment thread
ghostbuster91 marked this conversation as resolved.
Outdated
local function expand_node(node, expand_opts)
if not node then
return
end

if gen_iterator()(node) then
local descend_until = (expand_opts and expand_opts.descend_until) or descend_until_max_or_empty
if gen_iterator(descend_until)(node) then
notify.warn("expansion iteration was halted after " .. M.MAX_FOLDER_DISCOVERY .. " discovered folders")
end

Expand All @@ -89,18 +120,20 @@ end

---Expand the directory node or the root
---@param node Node
function M.all(node)
expand_node(node and node:as(DirectoryNode) or core.get_explorer())
---@param expand_opts ApiTreeExpandAllOpts?
function M.all(node, expand_opts)
expand_node(node and node:as(DirectoryNode) or core.get_explorer(), expand_opts)
end

---Expand the directory node or parent node
---@param node Node
function M.node(node)
---@param expand_opts ApiTreeExpandAllOpts?
function M.node(node, expand_opts)
if not node then
return
end

expand_node(node:is(FileNode) and node.parent or node:as(DirectoryNode))
expand_node(node:is(FileNode) and node.parent or node:as(DirectoryNode), expand_opts)
end

function M.setup(opts)
Expand Down
95 changes: 57 additions & 38 deletions lua/nvim-tree/api.lua
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,45 @@ local function wrap_explorer_member(explorer_member, member_method)
end)
end

---
---@class NodeEditOpts
---@field quit_on_open boolean|nil default false
---@field focus boolean|nil default true

---@param mode string
---@param node Node
---@param edit_opts NodeEditOpts?
local function edit(mode, node, edit_opts)
Comment thread
ghostbuster91 marked this conversation as resolved.
Outdated
local file_link = node:as(FileLinkNode)
local path = file_link and file_link.link_to or node.absolute_path
local cur_tabpage = vim.api.nvim_get_current_tabpage()

local explorer = core.get_explorer()

actions.node.open_file.fn(mode, path)

edit_opts = edit_opts or {}

local mode_unsupported_quit_on_open = mode == "drop" or mode == "tab_drop" or mode == "edit_in_place"
if not mode_unsupported_quit_on_open and edit_opts.quit_on_open then
if explorer then
explorer.view:close(cur_tabpage, "api.edit " .. mode)
end
end

local mode_unsupported_focus = mode == "drop" or mode == "tab_drop" or mode == "edit_in_place"
local focus = edit_opts.focus == nil or edit_opts.focus == true
if not mode_unsupported_focus and not focus then
-- if mode == "tabnew" a new tab will be opened and we need to focus back to the previous tab
if mode == "tabnew" then
vim.cmd(":tabprev")
end
if explorer then
explorer.view:focus()
end
end
end

---@class ApiTreeOpenOpts
---@field path string|nil path
---@field current_window boolean|nil default false
Expand Down Expand Up @@ -186,7 +225,25 @@ Api.tree.search_node = wrap(actions.finders.search_node.fn)
---@field keep_buffers boolean|nil default false

Api.tree.collapse_all = wrap(actions.tree.modifiers.collapse.all)

---@class ApiTreeExpandAllOpts
---@field descend_until (fun(expansion_count: integer, node: Node): boolean)|nil
Comment thread
ghostbuster91 marked this conversation as resolved.
Outdated

Api.tree.expand_all = wrap_node(actions.tree.modifiers.expand.all)

Api.tree.toggle_descend_until = wrap_node(function(node, descend_until)

@ghostbuster91 ghostbuster91 Jul 20, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: this is actually what I would like to achieve in the end. The edit part is wrong as nodes are not getting collapsed after hitting enter for the second time. Can you advise? fixed

question: how should the end user api look like?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be very useful, however it needs a bit of thought.

Can we please do this in a future PR? The functionality for the API expands is working and we can merge that now.

What should it look like? This isn't something the user should have to do; it should be core functionality.

It could go into node.open.edit, as a new member of NodeEditOpts

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing it in a separate PR makes perfect sense 👍

local dir = node:as(DirectoryNode)
if dir then
if node.open then
dir:expand_or_collapse(nil)
else
actions.tree.modifiers.expand.all(node, { descend_until = descend_until })
end
else
edit("edit", node)
end
end)

Api.tree.toggle_enable_filters = wrap_explorer_member("filters", "toggle")
Api.tree.toggle_gitignore_filter = wrap_explorer_member_args("filters", "toggle", "git_ignored")
Api.tree.toggle_git_clean_filter = wrap_explorer_member_args("filters", "toggle", "git_clean")
Expand Down Expand Up @@ -225,44 +282,6 @@ Api.fs.copy.absolute_path = wrap_node(wrap_explorer_member("clipboard", "copy_ab
Api.fs.copy.filename = wrap_node(wrap_explorer_member("clipboard", "copy_filename"))
Api.fs.copy.basename = wrap_node(wrap_explorer_member("clipboard", "copy_basename"))
Api.fs.copy.relative_path = wrap_node(wrap_explorer_member("clipboard", "copy_path"))
---
---@class NodeEditOpts
---@field quit_on_open boolean|nil default false
---@field focus boolean|nil default true

---@param mode string
---@param node Node
---@param edit_opts NodeEditOpts?
local function edit(mode, node, edit_opts)
local file_link = node:as(FileLinkNode)
local path = file_link and file_link.link_to or node.absolute_path
local cur_tabpage = vim.api.nvim_get_current_tabpage()

local explorer = core.get_explorer()

actions.node.open_file.fn(mode, path)

edit_opts = edit_opts or {}

local mode_unsupported_quit_on_open = mode == "drop" or mode == "tab_drop" or mode == "edit_in_place"
if not mode_unsupported_quit_on_open and edit_opts.quit_on_open then
if explorer then
explorer.view:close(cur_tabpage, "api.edit " .. mode)
end
end

local mode_unsupported_focus = mode == "drop" or mode == "tab_drop" or mode == "edit_in_place"
local focus = edit_opts.focus == nil or edit_opts.focus == true
if not mode_unsupported_focus and not focus then
-- if mode == "tabnew" a new tab will be opened and we need to focus back to the previous tab
if mode == "tabnew" then
vim.cmd(":tabprev")
end
if explorer then
explorer.view:focus()
end
end
end

---@param mode string
---@param toggle_group boolean?
Expand Down
Loading