Skip to content

fix(#3248): bookmark filter shows contents of marked directories #3249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-courtis merged 1 commit into from
Jan 23, 2026
+3 −0
Merged

fix(#3248): bookmark filter shows contents of marked directories #3249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lua/nvim-tree/explorer/filters.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,9 @@ function Filters:bookmark(path, path_type, bookmarks)

local mark_parent = utils.path_add_trailing(path)
for mark, mark_type in pairs(bookmarks) do

@alex-courtis alex-courtis Jan 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those variable names are quite misleading; mark is a path and mark_type is the actual bookmark. Not sure how that ever worked.

Tested OK

@xiantang xiantang Jan 23, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok let me update the var name

@alex-courtis alex-courtis Jan 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't stress, it's well outside of the scope of a bugfix.

@xiantang xiantang Jan 23, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will raise another PR to update the variable name. This will make things smaller and easier to review.

@alex-courtis alex-courtis Jan 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xiantang I really appreciate the extra effort.

@xiantang xiantang Jan 23, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see https://github.com/nvim-tree/nvim-tree.lua/pull/3250/files

if type(mark_type) == "table" and mark_type.type then
mark_type = mark_type.type
end
if path == mark then
return false
end
Expand Down
Loading