fix: correct broken tool definitions (#79)

* fix: correct broken tool definitions

Problem: several formatter and linter configs produced invalid commands
when invoked by guard.nvim. pylint, shellcheck, and rubocop were missing
fname=true so guard never appended the required filename argument.
hadolint lacked the '-' arg needed to read stdin. ruff linter used the
deprecated -e flag and was missing the 'check' subcommand. buf format
was configured for stdin which it does not support. csharpier referenced
the old dotnet-csharpier binary renamed in v1.0+. ruff_fix was missing
the 'check' subcommand.

Solution: add fname=true to pylint, shellcheck, and rubocop linters.
Add '-' to hadolint args. Replace ruff linter's -e with check
subcommand. Change buf from stdin to fname with -w flag. Update
csharpier cmd and args for v1.0+. Add check to ruff_fix args.

* test: add tests for fixed tool definitions

Problem: the config fixes in the previous commit had no test coverage
proving the definitions produce valid commands.

Solution: add opts (cwd, tmpdir) and assert_diag to the test helper.
Add tests for all 8 fixed tools using run_fmt/run_lint to exercise the
actual configs. Add pylint to pip.txt, hadolint to binary.txt,
shellcheck to the binary CI job, and new test-dotnet and test-ruby
CI jobs.

Author: barrettruth

.github/scripts/install-binary-tools.sh

@@ -30,5 +30,10 @@ while read -r name type url extra; do
       chmod +x "$dest/$name"
       rm -rf "$tmpdir"
       ;;
+    jar)
+      wget -q "$url" -O "$dest/$name.jar"
+      printf '#!/usr/bin/env bash\nexec java -jar "%s/%s.jar" "$@"\n' "$(cd "$dest" && pwd)" "$name" > "$dest/$name"
+      chmod +x "$dest/$name"
+      ;;
   esac
 done < "$manifest"

.github/tools/binary.txt

@@ -1,7 +1,12 @@
 alejandra bin https://github.com/kamadorueda/alejandra/releases/download/4.0.0/alejandra-x86_64-unknown-linux-musl
 buf bin https://github.com/bufbuild/buf/releases/download/v1.47.2/buf-Linux-x86_64
+hadolint bin https://github.com/hadolint/hadolint/releases/download/v2.12.0/hadolint-Linux-x86_64
 checkmake bin https://github.com/mrtazz/checkmake/releases/download/0.2.2/checkmake-0.2.2.linux.amd64
 deno zip https://github.com/denoland/deno/releases/download/v2.1.4/deno-x86_64-unknown-linux-gnu.zip
+detekt jar https://github.com/detekt/detekt/releases/download/v1.23.7/detekt-cli-1.23.7-all.jar
 hlint tar https://github.com/ndmitchell/hlint/releases/download/v3.10/hlint-3.10-x86_64-linux.tar.gz hlint-3.10/hlint
 latexindent bin https://github.com/cmhughes/latexindent.pl/releases/download/V3.24.4/latexindent-linux
 swiftformat zip https://github.com/nicklockwood/SwiftFormat/releases/download/0.55.3/swiftformat_linux.zip swiftformat_linux
+cbfmt tar https://github.com/lukas-reineke/cbfmt/releases/download/v0.2.0/cbfmt_linux-x86_64_v0.2.0.tar.gz cbfmt_linux-x86_64_v0.2.0/cbfmt
+dprint zip https://github.com/dprint/dprint/releases/download/0.49.0/dprint-x86_64-unknown-linux-gnu.zip
+ktlint bin https://github.com/pinterest/ktlint/releases/download/1.8.0/ktlint

.github/tools/npm.txt

@@ -2,3 +2,6 @@ prettier
 @biomejs/biome
 sql-formatter
 @taplo/cli
+eslint
+eslint_d
+stylelint

.github/tools/pip.txt

@@ -5,6 +5,7 @@ cpplint
 docformatter
 flake8
 mypy
+pylint
 ruff
 sqlfluff
 yapf

.github/workflows/ci.yaml

@@ -90,6 +90,7 @@ jobs:
       - name: Install tools
         run: |
           xargs -L1 go install < .github/tools/go.txt
+          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.64.8
           luarocks install busted --local
           luarocks install nlua --local
       - name: Clone guard.nvim
@@ -163,13 +164,17 @@ jobs:
         with:
           neovim: true
           version: nightly
+      - uses: actions/setup-java@v4
+        with:
+          distribution: temurin
+          java-version: 21
       - uses: leso-kn/gh-actions-lua@master
         with:
           luaVersion: "5.1"
       - uses: hishamhm/gh-actions-luarocks@master
       - name: Install tools
         run: |
-          sudo apt-get install -y zsh
+          sudo apt-get install -y zsh shellcheck
           luarocks install busted --local
           luarocks install nlua --local
           bash .github/scripts/install-binary-tools.sh "$HOME/.local/bin"
@@ -205,3 +210,62 @@ jobs:
           export LUA_PATH="lua/?.lua;lua/?/init.lua;$LUA_PATH"
           busted --lua nlua test/apt/*_spec.lua
 
+  test-dotnet:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: rhysd/action-setup-vim@v1
+        with:
+          neovim: true
+          version: nightly
+      - uses: actions/setup-dotnet@v4
+        with:
+          dotnet-version: '8.0'
+      - uses: leso-kn/gh-actions-lua@master
+        with:
+          luaVersion: "5.1"
+      - uses: hishamhm/gh-actions-luarocks@master
+      - name: Install tools
+        run: |
+          dotnet tool install -g csharpier
+          luarocks install busted --local
+          luarocks install nlua --local
+      - name: Clone guard.nvim
+        run: git clone --depth 1 https://github.com/nvimdev/guard.nvim && mv guard.nvim/lua/guard lua/
+      - name: Run tests
+        run: |
+          export LUA_PATH="lua/?.lua;lua/?/init.lua;$LUA_PATH"
+          busted --lua nlua test/dotnet/*_spec.lua
+
+  test-ruby:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: rhysd/action-setup-vim@v1
+        with:
+          neovim: true
+          version: nightly
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '3.3'
+      - uses: leso-kn/gh-actions-lua@master
+        with:
+          luaVersion: "5.1"
+      - uses: hishamhm/gh-actions-luarocks@master
+      - name: Install tools
+        run: |
+          gem install rubocop bundler
+          luarocks install busted --local
+          luarocks install nlua --local
+      - name: Setup rubocop Gemfile
+        run: |
+          mkdir -p /tmp/rubocop-test
+          printf "source 'https://rubygems.org'\ngem 'rubocop'\n" > /tmp/rubocop-test/Gemfile
+          cd /tmp/rubocop-test && bundle install
+      - name: Clone guard.nvim
+        run: git clone --depth 1 https://github.com/nvimdev/guard.nvim && mv guard.nvim/lua/guard lua/
+      - name: Run tests
+        run: |
+          export LUA_PATH="lua/?.lua;lua/?/init.lua;$LUA_PATH"
+          busted --lua nlua test/ruby/*_spec.lua
+

lua/guard-collection/formatter.lua

@@ -48,8 +48,8 @@ M.cljfmt = {
 }
 
 M.csharpier = {
-  cmd = 'dotnet-csharpier',
-  args = { '--write-stdout' },
+  cmd = 'csharpier',
+  args = { 'format', '--write-stdout' },
   stdin = true,
 }
 
@@ -299,7 +299,7 @@ M.ruff = {
 
 M.ruff_fix = {
   cmd = 'ruff',
-  args = { '--fix', '-', '--stdin-filename' },
+  args = { 'check', '--fix', '-', '--stdin-filename' },
   stdin = true,
   fname = true,
 }
@@ -319,8 +319,8 @@ M.biome = {
 
 M.buf = {
   cmd = 'buf',
-  args = { 'format' },
-  stdin = true,
+  args = { 'format', '-w' },
+  fname = true,
 }
 
 M.xmllint = {

lua/guard-collection/linter/hadolint.lua

@@ -1,6 +1,6 @@
 return {
   cmd = 'hadolint',
-  args = { '--no-fail', '--format=json' },
+  args = { '--no-fail', '--format=json', '-' },
   stdin = true,
   parse = require('guard.lint').from_json({
     attributes = {

lua/guard-collection/linter/pylint.lua

@@ -4,6 +4,7 @@ return {
   cmd = 'pylint',
   args = { '--from-stdin', '--output-format', 'json' },
   stdin = true,
+  fname = true,
   parse = lint.from_json({
     attributes = {
       severity = 'type',

lua/guard-collection/linter/rubocop.lua

@@ -4,6 +4,7 @@ return {
   cmd = 'bundle',
   args = { 'exec', 'rubocop', '--format', 'json', '--force-exclusion', '--stdin' },
   stdin = true,
+  fname = true,
   parse = lint.from_json({
     get_diagnostics = function(...)
       return vim.json.decode(...).files[1].offenses

lua/guard-collection/linter/ruff.lua

@@ -3,8 +3,8 @@ local lint = require('guard.lint')
 return {
   cmd = 'ruff',
   args = {
+    'check',
     '-n',
-    '-e',
     '--output-format',
     'json',
     '-',