phase 4: m_allocator.destroyBuffer(m_sbtBuffer) called twice#97
Open
Enhex wants to merge 1 commit into
Open
Conversation
Collaborator
|
Thanks, this make sense |
Collaborator
|
Sign-off is missing. If not done, I'll make the change. |
in phase 4 m_allocator.destroyBuffer(m_sbtBuffer) is called twice once in createRayTracingPipeline() and again when createRayTracingPipeline() calls createShaderBindingTable(). the buffer is only used and recreated inside createShaderBindingTable() so it should be safe to remove the destructor in createRayTracingPipeline() in phase 5 the code behaves like this and destroys it once in createShaderBindingTable(). Signed-off-by: Enhex <enhex0@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in phase 4 m_allocator.destroyBuffer(m_sbtBuffer) is called twice
once in createRayTracingPipeline()
and again when createRayTracingPipeline() calls createShaderBindingTable().
the buffer is only used and recreated inside createShaderBindingTable() so it should be safe to remove the destructor in createRayTracingPipeline()
in phase 5 the code behaves like this and destroys it once in createShaderBindingTable()