decode: added ability to reuse device for multiple files#120
Open
t-boiko wants to merge 1 commit into
Open
Conversation
t-boiko
commented
Dec 3, 2024
t-boiko
commented
Contributor
- added an ability to process several files in order by the same process in a linear order;
- added an ability to launch multiple decode processes and to handle them using a unix domain sockets.
t-boiko
force-pushed
the
decoder-multisession-mode
branch
2 times, most recently
from
December 3, 2024 11:10
1f0629c to
37888c5
Compare
zlatinski
requested changes
Dec 4, 2024
zlatinski
left a comment
zlatinski
left a comment
Contributor
There was a problem hiding this comment.
I need to spend more time reviewing the change. These are just a few comments on code clean-up and code style.
| if (result != VK_SUCCESS) { | ||
| return -1; | ||
| } | ||
| // result = VulkanVideoProcessor::Create(&vkDevCtxt, vulkanVideoProcessor); // moved closer to a decodeLoop |
Contributor
There was a problem hiding this comment.
Can you please remove all this commented-out code?
| // } | ||
| // } | ||
|
|
||
| // //Call WSAPoll for writeability of accepted |
Contributor
There was a problem hiding this comment.
Here too - remove this block of commented code, please.
| data_sent = 1; | ||
| } | ||
| if (ret) | ||
| { |
Contributor
There was a problem hiding this comment.
Please use a code formatter to fix all these inconsistencies of code style.
t-boiko
force-pushed
the
decoder-multisession-mode
branch
4 times, most recently
from
December 4, 2024 17:51
a5da5b6 to
5189559
Compare
t-boiko
force-pushed
the
decoder-multisession-mode
branch
5 times, most recently
from
January 20, 2025 16:45
8e0bd08 to
f7024a2
Compare
t-boiko
force-pushed
the
decoder-multisession-mode
branch
2 times, most recently
from
May 31, 2025 15:02
98955d7 to
cfb7b10
Compare
Signed-off-by: Tymur Boiko <tboiko@nvidia.com>
t-boiko
force-pushed
the
decoder-multisession-mode
branch
from
June 16, 2025 19:06
cfb7b10 to
78b3355
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.