Add nw.App.restart API#8351
Open
apples-kksk wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
nw.App.restart()and legacynw.gui.App.restart()by scheduling a relaunch during browser shutdown and then reusing the existing app quit path.The relaunch command preserves the original invocation argv, including argument order and
--handling, while normalizing the current NW app path so relative app launches restart correctly across platforms.Fixes #149
Tests:
git diff --checkpython3 -m py_compile test/sanity/app-restart/test.pypython3 -m json.tool test/sanity/app-restart/package.jsonNot run locally:
sanity/app-restart, because it requires CHROMEDRIVER/NW SDK build output.test/test.pyrunner, because Python 3.14 no longer includes theimpmodule used by the runner.