chore(ci): fix types (#18)

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>

Author: ayushmanchhabra

.github/workflows/ci.yml

@@ -41,6 +41,9 @@ jobs:
       - name: Check for type errors
         run: npm run type
 
+      - name: Check for typing errors
+        run: npm run type
+
       - name: Run tests with coverage
         id: coverage
         shell: bash

package-lock.json

@@ -53,6 +53,9 @@
   },
   "devDependencies": {
     "@eslint/js": "^9.39.2",
+    "@types/node": "^25.0.10",
+    "@types/semver": "^7.7.1",
+    "@types/yauzl-promise": "^4.0.1",
     "eslint": "^9.39.2",
     "eslint-plugin-jsdoc": "^62.1.0",
     "globals": "^17.0.0",

package.json

@@ -87,6 +87,7 @@ async function unzip(zippedFile, cacheDir) {
   for (const symlinkEntry of symlinks) {
     let entryPathAbs = path.join(cacheDir, symlinkEntry.filename);
     const readStream = await symlinkEntry.openReadStream();
+    /** @type {Buffer[]} */
     const chunks = [];
     readStream.on('data', (chunk) => chunks.push(chunk));
     await new Promise(resolve => readStream.on('end', resolve));

src/decompress.js

@@ -35,4 +35,5 @@ export default async function ffmpeg(downloadUrl, version, platform, arch, cache
     );
 
     await request(url, ffmpegFileAbs);
+    return ffmpegFileAbs;
 }

src/ffmpeg.js

@@ -54,10 +54,13 @@ async function get(options) {
     || options.version === "lts"
   ) {
     options.version = manifestData[options.version].slice(1);
-  } else if (semver.valid(semver.coerce(options.version))) {
-    options.version = semver.coerce(options.version).version;
   } else {
-    throw new Error('Expected "options.version" to be "latest", "stable", "lts" or a valid semver version. Received: ' + options.version);
+    const coerced = semver.coerce(options.version);
+    if (coerced && semver.valid(coerced)) {
+      options.version = coerced.version;
+    } else {
+      throw new Error('Expected "options.version" to be "latest", "stable", "lts" or a valid semver version. Received: ' + options.version);
+    }
   }
 
   if (options.flavor !== "normal" && options.flavor !== "sdk") {

src/main.js

@@ -45,4 +45,5 @@ export default async function nw(downloadUrl, version, cacheDir) {
   );
 
   await request(url, nwFileAbs);
+  return nwFileAbs;
 }

src/node.js

@@ -44,7 +44,7 @@ export default function request(url, filePath) {
       },
       (res) => {
         /* Redirect handling */
-        if (res.statusCode >= 300 && res.statusCode < 400 && res.headers.location) {
+        if (res.statusCode && res.statusCode >= 300 && res.statusCode < 400 && res.headers.location) {
           cleanup();
 
           const redirectedUrl = new URL(res.headers.location, parsedUrl).toString();

src/request.js

@@ -5,7 +5,14 @@
     "declaration": true,
     "emitDeclarationOnly": true,
     "outDir": "types",
-    "strict": true
+    "strict": true,
+    "target": "ES2020",
+    "lib": ["ES2020"],
+    "module": "ESNext",
+    "moduleResolution": "node",
+    "types": ["node"],
+    "esModuleInterop": true,
+    "allowSyntheticDefaultImports": true
   },
   "include": [
     "src/**/*.js"