Skip to content

Commit de8bb15

Browse files
committed
fixup: remove encoding test
1 parent 9fbb8d4 commit de8bb15

File tree

1 file changed

+0
-20
lines changed

1 file changed

+0
-20
lines changed

test/parallel/test-transform-by.js

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -74,24 +74,6 @@ async function transformByFuncReturnsObjectWithoutSymbolAsyncIterator() {
7474
});
7575
}
7676

77-
async function transformByEncoding() {
78-
const readable = Readable.from('test'.split(''));
79-
async function * mapper(source) {
80-
for await (const chunk of source) {
81-
strictEqual(source.encoding, 'ascii');
82-
yield chunk.toUpperCase();
83-
}
84-
}
85-
const stream = Transform.by(mapper);
86-
stream.setDefaultEncoding('ascii');
87-
readable.pipe(stream);
88-
89-
const expected = ['T', 'E', 'S', 'T'];
90-
for await (const chunk of stream) {
91-
strictEqual(chunk, expected.shift());
92-
}
93-
}
94-
9577
async function transformBySourceIteratorCompletes() {
9678
const readable = Readable.from('test'.split(''));
9779
const mustReach = mustCall();
@@ -272,8 +254,6 @@ Promise.all([
272254
transformByObjReturnedWSymbolAsyncIteratorWithNoNext(),
273255
transformByObjReturnedWSymbolAsyncIteratorThatIsNotFunction(),
274256
transformByFuncReturnsObjectWithoutSymbolAsyncIterator(),
275-
// NOTE: This doesn't make sense for iterable? Is it consistent with Readable.from?
276-
// transformByEncoding(),
277257
transformBySourceIteratorCompletes(),
278258
transformByYieldPlusReturn(),
279259
transformByReturnEndsStream(),

0 commit comments

Comments
 (0)