Skip to content

Commit ac4539a

Browse files
[chore]: refactor & fix lint for browse CLI (browserbase#1821)
1 parent 2402a3c commit ac4539a

14 files changed

Lines changed: 230 additions & 1132 deletions

File tree

.github/workflows/ci.yml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,24 @@ jobs:
257257
packages/server-v4/openapi.v4.yaml
258258
retention-days: 1
259259

260+
run-cli-tests:
261+
name: CLI Tests
262+
runs-on: ubuntu-latest
263+
needs: [run-build, determine-changes]
264+
if: needs.determine-changes.outputs.cli == 'true'
265+
steps:
266+
- uses: actions/checkout@v4
267+
with:
268+
fetch-depth: 1
269+
270+
- uses: ./.github/actions/setup-node-pnpm-turbo
271+
with:
272+
use-prebuilt-artifacts: "true"
273+
restore-turbo-cache: "false"
274+
275+
- name: Run CLI Tests
276+
run: pnpm exec turbo run test:cli --filter=@browserbasehq/browse-cli
277+
260278
discover-core-tests:
261279
runs-on: ubuntu-latest
262280
needs: [determine-changes]

.prettierignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ lib/v3/dom/build/
1010
packages/core/dist/
1111
packages/core/lib/dom/build/
1212
packages/core/lib/v3/dom/build/
13+
packages/cli/dist/
1314
packages/evals/dist/
1415
packages/docs/
1516
*.min.js

eslint.config.mjs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,10 @@ export default [
1818
],
1919
languageOptions: { globals: globals.node },
2020
},
21+
{
22+
files: ["packages/cli/**/*.{js,cjs,mjs,ts}"],
23+
languageOptions: { globals: globals.node },
24+
},
2125
{
2226
ignores: [
2327
"**/dist/**",
@@ -73,4 +77,10 @@ export default [
7377
],
7478
},
7579
},
80+
{
81+
files: ["packages/cli/**/*.{js,cjs,mjs,ts}"],
82+
rules: {
83+
"no-empty": ["error", { allowEmptyCatch: true }],
84+
},
85+
},
7686
];

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"format": "prettier --write .",
1818
"prettier": "prettier --write .",
1919
"eslint": "eslint .",
20-
"test": "turbo run test:core test:e2e test:server test:evals",
20+
"test": "turbo run test:core test:e2e test:server test:evals test:cli",
2121
"test:core": "turbo run test:core --",
2222
"test:core:local": "STAGEHAND_BROWSER_TARGET=local pnpm run test:core --",
2323
"test:core:bb": "STAGEHAND_BROWSER_TARGET=browserbase pnpm run test:core --",

packages/cli/.prettierignore

Lines changed: 0 additions & 3 deletions
This file was deleted.

packages/cli/.prettierrc

Lines changed: 0 additions & 1 deletion
This file was deleted.

packages/cli/eslint.config.mjs

Lines changed: 0 additions & 32 deletions
This file was deleted.

packages/cli/package.json

Lines changed: 9 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
"stagehand"
2828
],
2929
"engines": {
30-
"node": ">=18.0.0"
30+
"node": "^20.19.0 || >=22.12.0"
3131
},
3232
"publishConfig": {
3333
"access": "public"
@@ -46,13 +46,12 @@
4646
"dev": "tsx src/index.ts",
4747
"browse": "tsx src/index.ts",
4848
"typecheck": "tsc --noEmit",
49-
"lint": "eslint .",
50-
"lint:fix": "eslint . --fix",
51-
"format": "prettier --write .",
52-
"format:check": "prettier --check .",
49+
"eslint": "eslint .",
50+
"lint": "cd ../.. && prettier --check packages/cli && cd packages/cli && pnpm run eslint && pnpm run typecheck",
5351
"test": "vitest run",
52+
"test:cli": "vitest run",
5453
"test:watch": "vitest",
55-
"prepublishOnly": "npm run build"
54+
"prepublishOnly": "pnpm run build"
5655
},
5756
"dependencies": {
5857
"@browserbasehq/stagehand": "workspace:*",
@@ -62,24 +61,13 @@
6261
"pino-pretty": "^13.0.0",
6362
"ws": "^8.18.0"
6463
},
65-
"peerDependencies": {
66-
"playwright": "^1.50.0"
67-
},
68-
"peerDependenciesMeta": {
69-
"playwright": {
70-
"optional": true
71-
}
72-
},
7364
"devDependencies": {
74-
"@eslint/js": "^9.16.0",
7565
"@types/node": "^20.11.30",
76-
"eslint": "^9.16.0",
77-
"globals": "^15.13.0",
78-
"prettier": "^3.2.5",
66+
"devtools-protocol": "^0.0.1464554",
67+
"eslint": "^10.0.2",
7968
"tsup": "^8.2.1",
8069
"tsx": "^4.10.5",
81-
"typescript": "^5.2.2",
82-
"typescript-eslint": "^8.17.0",
83-
"vitest": "^1.6.0"
70+
"typescript": "5.8.3",
71+
"vitest": "^4.0.8"
8472
}
8573
}

0 commit comments

Comments
 (0)