Skip to content

Commit 0e5ae03

Browse files
committed
Remove unsupported domain list filters
1 parent 999315c commit 0e5ae03

2 files changed

Lines changed: 3 additions & 13 deletions

File tree

src/main/kotlin/com/nylas/models/ListDomainsQueryParams.kt

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,21 +10,13 @@ data class ListDomainsQueryParams(
1010
val limit: Int? = null,
1111
@Json(name = "page_token")
1212
val pageToken: String? = null,
13-
@Json(name = "domain")
14-
val domain: String? = null,
15-
@Json(name = "region")
16-
val region: Region? = null,
1713
) : IQueryParams {
1814
class Builder {
1915
private var limit: Int? = null
2016
private var pageToken: String? = null
21-
private var domain: String? = null
22-
private var region: Region? = null
2317

2418
fun limit(limit: Int?) = apply { this.limit = limit }
2519
fun pageToken(pageToken: String?) = apply { this.pageToken = pageToken }
26-
fun domain(domain: String?) = apply { this.domain = domain }
27-
fun region(region: Region?) = apply { this.region = region }
28-
fun build() = ListDomainsQueryParams(limit, pageToken, domain, region)
20+
fun build() = ListDomainsQueryParams(limit, pageToken)
2921
}
3022
}

src/test/kotlin/com/nylas/resources/DomainsTests.kt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -193,12 +193,10 @@ class DomainsTests {
193193
val queryParams = ListDomainsQueryParams.Builder()
194194
.limit(5)
195195
.pageToken("cursor123")
196-
.domain("mail.acme.com")
197-
.region(Region.US)
198196
.build()
199197

200198
assertEquals(
201-
mapOf("limit" to 5.0, "page_token" to "cursor123", "domain" to "mail.acme.com", "region" to "us"),
199+
mapOf("limit" to 5.0, "page_token" to "cursor123"),
202200
queryParams.convertToMap(),
203201
)
204202
}
@@ -368,7 +366,7 @@ class DomainsTests {
368366

369367
@Test
370368
fun `listing managed domains calls requests with the correct params`() {
371-
val queryParams = ListDomainsQueryParams(limit = 5, pageToken = "cursor123", domain = "mail.acme.com", region = Region.US)
369+
val queryParams = ListDomainsQueryParams(limit = 5, pageToken = "cursor123")
372370
val overrides = serviceAccountOverrides()
373371
domains.list(queryParams, overrides)
374372

0 commit comments

Comments
 (0)