Skip to content

Commit 2869c28

Browse files
committed
Split domain verification request types
1 parent 6047079 commit 2869c28

2 files changed

Lines changed: 9 additions & 14 deletions

File tree

src/main/kotlin/com/nylas/models/DomainVerification.kt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,6 @@ enum class DomainVerificationRequestType {
4646

4747
@Json(name = "feedback")
4848
FEEDBACK,
49-
50-
@Json(name = "dmarc")
51-
DMARC,
52-
53-
@Json(name = "arc")
54-
ARC,
5549
}
5650

5751
/**

src/test/kotlin/com/nylas/resources/DomainsTests.kt

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,15 @@ class DomainsTests {
179179
assertEquals("""{"name":"Renamed"}""", json)
180180
}
181181

182+
@Test
183+
fun `DomainVerificationResult deserializes extended response verification types`() {
184+
val adapter = JsonHelper.moshi().adapter(DomainVerificationResult::class.java)
185+
val result = adapter.fromJson("""{"domain_id":"dom-123","attempt":{"type":"dmarc"},"status":"pending"}""")!!
186+
187+
assertEquals(DomainVerificationType.DMARC, result.attempt?.type)
188+
assertEquals(DomainVerificationStatus.PENDING, result.status)
189+
}
190+
182191
@Test
183192
fun `ListDomainsQueryParams only exposes documented query parameters`() {
184193
val queryParams = ListDomainsQueryParams.Builder()
@@ -193,14 +202,6 @@ class DomainsTests {
193202
queryParams.convertToMap(),
194203
)
195204
}
196-
197-
@Test
198-
fun `DomainVerificationRequest supports all public verification request types`() {
199-
val adapter = JsonHelper.moshi().adapter(DomainVerificationRequest::class.java)
200-
201-
assertEquals("""{"type":"dmarc"}""", adapter.toJson(DomainVerificationRequest(DomainVerificationRequestType.DMARC)))
202-
assertEquals("""{"type":"arc"}""", adapter.toJson(DomainVerificationRequest(DomainVerificationRequestType.ARC)))
203-
}
204205
}
205206

206207
@Nested

0 commit comments

Comments
 (0)