Merge pull request #147 from nylas/datetime-timedelta-ensure-int

Cast to int when converting timedelta to minutes

Author: David Baumgold

CHANGELOG.md

@@ -3,7 +3,8 @@ nylas-python Changelog
 
 Unreleased (dev)
 ----------------
-nothing yet
+* Bugfix: Previously, if you passed a timedelta to the calendar availability
+  API endpoint, it was converted to a float. Now, it is coerced to an int.
 
 v4.12.0
 -------

nylas/client/client.py

@@ -249,11 +249,11 @@ def availability(
         if isinstance(emails, six.string_types):
             emails = [emails]
         if isinstance(duration, timedelta):
-            duration_minutes = duration.total_seconds() // 60
+            duration_minutes = int(duration.total_seconds() // 60)
         else:
             duration_minutes = int(duration)
         if isinstance(interval, timedelta):
-            interval_minutes = interval.total_seconds() // 60
+            interval_minutes = int(interval.total_seconds() // 60)
         else:
             interval_minutes = int(interval)
         if isinstance(start_at, datetime):

tests/test_events.py

@@ -169,7 +169,9 @@ def test_availability_datetime(mocked_responses, api_client):
     data = json.loads(request.body)
     assert data["emails"] == emails
     assert data["duration_minutes"] == 30
+    assert isinstance(data["duration_minutes"], int)
     assert data["interval_minutes"] == 90
+    assert isinstance(data["interval_minutes"], int)
     assert data["start_time"] == 1577836800
     assert data["end_time"] == 1577923200
     assert data["free_busy"] == []
@@ -194,7 +196,9 @@ def test_availability_timestamp(mocked_responses, api_client):
     data = json.loads(request.body)
     assert data["emails"] == emails
     assert data["duration_minutes"] == 30
+    assert isinstance(data["duration_minutes"], int)
     assert data["interval_minutes"] == 60
+    assert isinstance(data["interval_minutes"], int)
     assert data["start_time"] == 1580511600
     assert data["end_time"] == 1580598000
     assert data["free_busy"] == []
@@ -217,7 +221,9 @@ def test_availability_single_email(mocked_responses, api_client):
     data = json.loads(request.body)
     assert data["emails"] == [email]
     assert data["duration_minutes"] == 60
+    assert isinstance(data["duration_minutes"], int)
     assert data["interval_minutes"] == 5
+    assert isinstance(data["interval_minutes"], int)
     assert data["start_time"] == 946684800
     assert data["end_time"] == 951868800
     assert data["free_busy"] == []
@@ -260,7 +266,9 @@ def test_availability_with_free_busy(mocked_responses, api_client):
     data = json.loads(request.body)
     assert data["emails"] == emails
     assert data["duration_minutes"] == 48
+    assert isinstance(data["duration_minutes"], int)
     assert data["interval_minutes"] == 18
+    assert isinstance(data["interval_minutes"], int)
     assert data["start_time"] == 1577836800
     assert data["end_time"] == 1577923200
     assert data["free_busy"] == free_busy