Skip to content

Commit fa6b384

Browse files
committed
Support custom attachment filename for large files
1 parent c508d84 commit fa6b384

2 files changed

Lines changed: 10 additions & 1 deletion

File tree

lib/nylas/utils/file_utils.rb

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,13 @@ def self.build_form_request(request_body)
3636
file = File.open(attachment[:file_path], "rb")
3737
end
3838

39+
# Setting original filename and content type if available. See code rest-client#lib/restclient/payload.rb
40+
filename = attachment[:filename] || attachment["filename"]
41+
file.define_singleton_method(:original_filename) { filename } if filename
42+
43+
content_type = attachment[:content_type] || attachment["content_type"]
44+
file.define_singleton_method(:content_type) { content_type } if content_type
45+
3946
form_data.merge!({ "file#{index}" => file })
4047
opened_files << file
4148
end

spec/nylas/utils/file_utils_spec.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@
192192
let(:mock_file) { instance_double("file") }
193193

194194
it "returns form data when attachment size is greater than 3MB" do
195-
large_attachment = { size: 4 * 1024 * 1024, content: mock_file }
195+
large_attachment = { size: 4 * 1024 * 1024, content: mock_file, filename: 'file.txt', content_type: 'text/plain' }
196196
request_body = { attachments: [large_attachment] }
197197

198198
allow(mock_file).to receive(:read).and_return("file content")
@@ -202,6 +202,8 @@
202202

203203
expect(payload).to include("multipart" => true)
204204
expect(opened_files).to include(mock_file)
205+
expect(mock_file.original_filename).to eq('file.txt')
206+
expect(mock_file.content_type).to eq('text/plain')
205207
end
206208

207209
it "returns json data when attachment size is less than 3MB" do

0 commit comments

Comments
 (0)