chore: add .editorconfig, minor cleanups#32
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
=======================================
Coverage 89.74% 89.74%
=======================================
Files 3 3
Lines 78 78
Branches 78 78
=======================================
Hits 70 70
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR enhances the repository's code quality infrastructure by adding comprehensive EditorConfig settings and performing minor maintenance cleanups. The changes standardize formatting rules across different file types and simplify MSRV (Minimum Supported Rust Version) testing procedures.
Key changes:
- Added detailed
.editorconfigwith file-type-specific indentation rules (2 spaces for YAML/Markdown, 4 spaces default) - Integrated
editorconfig-checkerinto pre-commit hooks for automated enforcement - Simplified MSRV testing by consolidating separate check and test recipes into a single check command
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.editorconfig |
Expanded configuration with alphabetically sorted rules, added end_of_line enforcement, and file-type-specific indentation (YAML/Markdown: 2 spaces, LICENSE files: unset) |
.pre-commit-config.yaml |
Added editorconfig-checker hook (v3.6.0) to automatically validate EditorConfig compliance |
justfile |
Completed incomplete comment on line 3, removed separate check-msrv and test-msrv recipes in favor of simplified ci-test-msrv, and fixed shell block indentation in assert-git-is-clean to use consistent 4-space indentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ci-test-msrv: env-info | ||
| cargo check --all-features --package {{main_crate}} |
There was a problem hiding this comment.
The MSRV verification has been significantly simplified. The new implementation only checks compilation of the main crate library with all features, whereas the previous implementation checked all targets (including tests, benches, and examples via --all-targets) and ran tests across the workspace.
This means MSRV compatibility is no longer verified for:
- Test code, benchmarks, and examples (missing
--all-targets) - Runtime behavior (tests are no longer executed)
If this simplification is intentional, consider documenting the reasoning. Otherwise, consider restoring --all-targets at minimum, or test execution if runtime MSRV compatibility is important.
No description provided.