Skip to content

fix: Unrestricted file content processing #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrwind-up-bird wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Unrestricted file content processing #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions app/services/extract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@
MAX_FILE_SIZE = 10 * 1024 * 1024 # 10 MB


# Validate file size to prevent memory exhaustion
if len(content) > MAX_FILE_SIZE:
raise ValueError(f"File size {len(content)} bytes exceeds maximum allowed size of {MAX_FILE_SIZE} bytes")

def extract_text(filename: str, content: bytes) -> str:
"""Extract plain text from file bytes based on the file extension.

Expand All @@ -34,6 +38,16 @@ def extract_text(filename: str, content: bytes) -> str:
return _extract_docx(content)

raise ValueError(f"Unsupported file type: {ext}")
try:
# Limit number of pages to prevent resource exhaustion
max_pages = 1000
if len(reader.pages) > max_pages:
raise ValueError(f"PDF has {len(reader.pages)} pages, exceeding maximum of {max_pages}")
except Exception as e:
raise ValueError(f"Failed to process PDF file: {str(e)}")
try:
except Exception as e:
raise ValueError(f"Failed to process DOCX file: {str(e)}")


def _extract_pdf(content: bytes) -> str:
Expand Down