Skip to content

Commit be16570

Browse files
feat: Made linter disable allowed
1 parent 8348971 commit be16570

3 files changed

Lines changed: 40 additions & 15 deletions

File tree

src/main/java/studio/o7/remora/RemoraPlugin.java

Lines changed: 32 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,7 @@
1818
import org.gradle.api.logging.Logger;
1919
import org.gradle.api.plugins.ExtensionContainer;
2020
import org.gradle.api.plugins.JavaLibraryPlugin;
21-
import org.gradle.api.plugins.quality.CheckstyleExtension;
22-
import org.gradle.api.plugins.quality.CheckstylePlugin;
23-
import org.gradle.api.plugins.quality.PmdExtension;
24-
import org.gradle.api.plugins.quality.PmdPlugin;
21+
import org.gradle.api.plugins.quality.*;
2522
import org.gradle.api.publish.PublishingExtension;
2623
import org.gradle.api.tasks.bundling.Jar;
2724
import org.gradle.plugins.signing.SigningExtension;
@@ -172,9 +169,29 @@ public void apply(Project project) {
172169

173170
RemoraPlugins.applyBuildConstants(logger, project);
174171

175-
applyCheckstyle(logger, project);
176-
applyPmd(logger, project);
177-
applySpotBugs(logger, project);
172+
if (!isDisabled("checkstyle")) {
173+
applyCheckstyle(logger, project);
174+
} else {
175+
logger.lifecycle("Skipping Checkstyle (disabled via env/property)");
176+
project.getTasks().withType(Checkstyle.class)
177+
.configureEach(task -> task.setEnabled(false));
178+
}
179+
180+
if (!isDisabled("pmd")) {
181+
applyPmd(logger, project);
182+
} else {
183+
logger.lifecycle("Skipping PMD (disabled via env/property)");
184+
project.getTasks().withType(Pmd.class)
185+
.configureEach(task -> task.setEnabled(false));
186+
}
187+
188+
if (!isDisabled("spotbugs")) {
189+
applySpotBugs(logger, project);
190+
} else {
191+
logger.lifecycle("Skipping SpotBugs (disabled via env/property)");
192+
project.getTasks().withType(SpotBugsTask.class)
193+
.configureEach(task -> task.setEnabled(false));
194+
}
178195

179196
applyManifest(project);
180197
}
@@ -187,4 +204,12 @@ public static void applyManifest(@NonNull Project project) {
187204
"Remora", "Build with o7studios Remora"
188205
))));
189206
}
207+
208+
private static boolean isDisabled(String name) {
209+
if ("true".equalsIgnoreCase(System.getProperty("remora.skip-" + name))) {
210+
return true;
211+
}
212+
213+
return "true".equalsIgnoreCase(System.getenv("REMORA_SKIP_" + name.toUpperCase()));
214+
}
190215
}

src/main/java/studio/o7/remora/plugin/PaperPlugins.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,15 @@
1818
public class PaperPlugins {
1919

2020
public static void setupExtension(@NonNull Logger logger, @NonNull ExtensionContainer extensions) throws IllegalArgumentException {
21-
logger.lifecycle("Setting up the `plugin` extension");
21+
logger.info("Setting up the `plugin` extension");
2222
extensions.create("plugin", PluginExtension.class);
2323
}
2424

2525
public void configureProject(@NonNull Logger logger, @NonNull Project project) {
2626
var extension = project.getExtensions().findByType(PluginExtension.class);
2727
if (extension == null) return;
2828
if (!extension.getEnabled().orElse(false).get()) return;
29-
logger.lifecycle("Configuring paper plugin with `plugin` extension");
29+
logger.info("Configuring paper plugin with `plugin` extension");
3030
var infoExtension = project.getExtensions().getByType(InformationExtension.class);
3131

3232
var builder = PluginConfig.builder();
@@ -37,11 +37,11 @@ public void configureProject(@NonNull Logger logger, @NonNull Project project) {
3737
var apiVersion = extension.getApiVersion().orElse(ApiVersion.DEFAULT).get();
3838

3939
var apiDependency = apiVersion.getApiDependency();
40-
logger.lifecycle("Adding paper-api dependency: {}", apiDependency);
40+
logger.info("Adding paper-api dependency: {}", apiDependency);
4141
dependencies.add("compileOnlyApi", apiDependency);
4242

4343
var pluginApiVersion = apiVersion.getApiVersion();
44-
logger.lifecycle("Setting api-version: {}", pluginApiVersion);
44+
logger.info("Setting api-version: {}", pluginApiVersion);
4545
builder.apiVersion(pluginApiVersion);
4646

4747

@@ -50,7 +50,7 @@ public void configureProject(@NonNull Logger logger, @NonNull Project project) {
5050
builder.libraries(libraries);
5151

5252
for (var library : libraries) {
53-
logger.lifecycle("Adding library as dependency: {}", library);
53+
logger.info("Adding library as dependency: {}", library);
5454
dependencies.add("compileOnlyApi", library);
5555
}
5656

@@ -124,7 +124,7 @@ public void configureProject(@NonNull Logger logger, @NonNull Project project) {
124124
pluginConfig.writeYaml(fos);
125125
}
126126

127-
logger.lifecycle("Generated `paper-plugin.yml`");
127+
logger.info("Generated `paper-plugin.yml`");
128128
} catch (Exception exception) {
129129
throw new GradleException("Failed to generate paper-plugin.yml", exception);
130130
}

src/main/java/studio/o7/remora/plugins/RemoraPlugins.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public void applyBuildConstants(@NonNull Logger logger, @NonNull Project project
1919
project.getTasks().withType(BuildConstantsTask.class).configureEach(task -> {
2020
var group = String.valueOf(project.getGroup());
2121
if (!group.isEmpty()) {
22-
logger.lifecycle("Setting constants {}", group);
22+
logger.info("Setting constants {}", group);
2323
task.getClassname().set(group + ".BuildConstants");
2424
} else {
2525
task.getClassname().set(project.getName() + ".BuildConstants");
@@ -36,7 +36,7 @@ public void applyBuildConstants(@NonNull Logger logger, @NonNull Project project
3636
}
3737

3838
public void applyShadowJar(@NonNull Logger logger, @NonNull Project project) {
39-
logger.lifecycle("Configuring task `shadowJar`");
39+
logger.info("Configuring task `shadowJar`");
4040

4141
var task = project.getTasks().withType(ShadowJar.class);
4242

0 commit comments

Comments
 (0)