Skip to content

Commit fc18405

Browse files
fix: Extensions
1 parent 134585a commit fc18405

8 files changed

Lines changed: 47 additions & 133 deletions

File tree

src/main/java/studio/o7/remora/RemoraPlugin.java

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
import org.gradle.api.provider.Property;
1515
import org.gradle.api.publish.maven.plugins.MavenPublishPlugin;
1616
import org.gradle.plugins.signing.SigningPlugin;
17-
import studio.o7.remora.extensions.DefaultRemoraExtension;
18-
import studio.o7.remora.extensions.FrameworkExtension;
1917
import studio.o7.remora.extensions.RemoraExtension;
2018

2119
public class RemoraPlugin implements Plugin<Project> {
@@ -40,17 +38,13 @@ public void apply(Project project) {
4038

4139
public static RemoraExtension setupExtension(@NonNull Logger logger, @NonNull ExtensionContainer extensions) {
4240
logger.info("Setting up the `remora` extension");
43-
return extensions.create("remora", DefaultRemoraExtension.class);
41+
return extensions.create("remora", RemoraExtension.class);
4442
}
4543

4644
public static void applyNecessaryProjectConfiguration(@NonNull Logger logger, @NonNull Project project, @NonNull RemoraExtension extension) {
4745
logger.info("Applying project `group` and `description` configuration");
48-
project.setGroup(extension.getGroupId().get());
49-
50-
Property<String> description = extension.getDescription();
51-
if (description.isPresent()) {
52-
project.setDescription(description.get());
53-
}
46+
project.setGroup(extension.getGroupId());
47+
project.setDescription(extension.getDescription());
5448
}
5549

5650
public static void applyJavaPluginConfiguration(@NonNull Logger logger, @NonNull Project project, @NonNull RemoraExtension extension) {
@@ -81,6 +75,7 @@ public static void applyNecessaryRepositories(@NonNull Logger logger, @NonNull P
8175
public static void applyDependencies(@NonNull Logger logger, @NonNull Project project, @NonNull RemoraExtension extension) {
8276
DependencyHandler dependencies = project.getDependencies();
8377

78+
/*
8479
FrameworkExtension framework = null;
8580
8681
logger.info("Adding dependency `lombok`");
@@ -98,6 +93,7 @@ public static void applyDependencies(@NonNull Logger logger, @NonNull Project pr
9893
9994
dependencies.add(fastUtils.getScope().getConfigurationName(), id);
10095
}
96+
*/
10197
}
10298

10399
public static void applyPlaceholderConfiguration(@NonNull Logger logger, @NonNull Project project, @NonNull RemoraExtension extension) {

src/main/java/studio/o7/remora/extensions/DefaultRemoraExtension.java

Lines changed: 0 additions & 12 deletions
This file was deleted.

src/main/java/studio/o7/remora/extensions/FrameworkExtension.java

Lines changed: 0 additions & 18 deletions
This file was deleted.

src/main/java/studio/o7/remora/extensions/PublishingExtension.java

Lines changed: 0 additions & 44 deletions
This file was deleted.
Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,26 @@
11
package studio.o7.remora.extensions;
22

3-
import org.gradle.api.provider.Property;
4-
import org.gradle.api.tasks.Optional;
3+
import lombok.Getter;
4+
import lombok.Setter;
5+
import org.gradle.api.model.ObjectFactory;
56
import org.gradle.jvm.toolchain.JavaLanguageVersion;
7+
import studio.o7.remora.extensions.framework.FrameworkExtension;
68

7-
public interface RemoraExtension {
9+
@Getter
10+
@Setter
11+
public class RemoraExtension {
812

9-
Property<String> getGroupId();
13+
private String groupId;
1014

11-
Property<String> getArtifactId();
15+
private String artifactId;
1216

13-
@Optional
14-
Property<String> getDescription();
17+
private String description;
1518

16-
@Optional
17-
Property<JavaLanguageVersion> getJavaVersion();
19+
private JavaLanguageVersion javaVersion = JavaLanguageVersion.of(23);
1820

21+
private FrameworkExtension framework;
22+
23+
public RemoraExtension(ObjectFactory factory) {
24+
this.framework = factory.newInstance(FrameworkExtension.class);
25+
}
1926
}

src/main/java/studio/o7/remora/extensions/RemoraOldExtension.java

Lines changed: 0 additions & 41 deletions
This file was deleted.
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
package studio.o7.remora.extensions.framework;
2+
3+
import lombok.Getter;
4+
import lombok.Setter;
5+
import org.gradle.api.model.ObjectFactory;
6+
7+
@Getter
8+
@Setter
9+
public class FrameworkExtension {
10+
private LombokExtension lombok;
11+
12+
public FrameworkExtension(ObjectFactory factory) {
13+
lombok = factory.newInstance(LombokExtension.class);
14+
}
15+
}
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
package studio.o7.remora.extensions.framework;
2+
3+
import lombok.Getter;
4+
import lombok.Setter;
5+
6+
@Getter
7+
@Setter
8+
public class LombokExtension {
9+
private boolean enabled = true;
10+
private String version = "1.18.36";
11+
}

0 commit comments

Comments
 (0)