Skip to content

C10s#117

Merged
dupondje merged 8 commits into
mainfrom
c10s
May 13, 2025
Merged

C10s#117
dupondje merged 8 commits into
mainfrom
c10s

Conversation

@dupondje
Copy link
Copy Markdown
Member

@dupondje dupondje commented May 7, 2025

Fixes to support c10s

This fixes the following warnings:
warning: line 24: It's not recommended to have unversioned Obsoletes: Obsoletes: python3.11-ovirt-engine-sdk4
warning: line 25: It's not recommended to have unversioned Obsoletes: Obsoletes: python3.12-ovirt-engine-sdk4

Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
@dupondje dupondje requested a review from mnecas as a code owner May 7, 2025 10:58
As distutils is removed in Python 3.12, replace the functionality with
setuptools.Extension.

Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
dupondje added 2 commits May 8, 2025 11:50
Add build for CentOS Stream 10

Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
Drop python3-pycodestyle and python3-pyflakes as those are not used
anymore in the project.

Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
@dupondje
Copy link
Copy Markdown
Member Author

dupondje commented May 9, 2025

Added python3-nose2 to virt10s-ovirt-45-testing and virt9s-ovirt-45-testing

Copy link
Copy Markdown
Member

@sandrobonazzola sandrobonazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread tests/server.py Fixed
@dupondje dupondje marked this pull request as draft May 12, 2025 14:01
@dupondje dupondje force-pushed the c10s branch 13 times, most recently from 72b7eb8 to df92628 Compare May 13, 2025 09:49
A lot of things needed to be excluded.
Used https://github.com/github/gitignore/blob/main/Python.gitignore as a
base.

Removed the egg-info folder which should not be in git.

Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
dupondje added 3 commits May 13, 2025 13:15
- As python-nose is deprecated, move all tests to pytest.
- Add tox to run the tests.
- Add flake8 as linter
- Run tox during CI.
- Let the HTTP server return Content-Length for tests.
  As otherwise tests are broken since newer OpenSSL version [1]

[1]: curl/curl#13389

Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
Fix all the lint errors reported by flake8.
Exclude E131 and E501.

Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
Adjust the setup.py with 'oVirt Developers' as authors and use the new
license argument.

Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
@dupondje dupondje marked this pull request as ready for review May 13, 2025 11:24
@dupondje dupondje merged commit 239d39b into main May 13, 2025
9 checks passed
@dupondje dupondje deleted the c10s branch May 13, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants