refactor: return early if no options

Jamie Tanna · Jamie Tanna · commit b73ed97520b1 · 2025-04-24T11:00:18.000+01:00
As it simplifies the readability of the checks.
diff --git a/oapi_validate.go b/oapi_validate.go
@@ -70,10 +70,13 @@ func OapiRequestValidatorWithOptions(spec *openapi3.T, options *Options) func(ne
 				return
 			}
 
-			if options != nil && options.ErrorHandler != nil {
-				options.ErrorHandler(w, err.Error(), statusCode)
-			} else {
+			if options == nil {
 				http.Error(w, err.Error(), statusCode)
+				return
+			}
+
+			if options.ErrorHandler != nil {
+				options.ErrorHandler(w, err.Error(), statusCode)
 			}
 		})
 	}

Original file line number	Diff line number	Diff line change
`@@ -70,10 +70,13 @@ func OapiRequestValidatorWithOptions(spec openapi3.T, options Options) func(ne`
`70`	`70`	`return`
`71`	`71`	`}`
`72`	`72`
`73`		`- if options != nil && options.ErrorHandler != nil {`
`74`		`- options.ErrorHandler(w, err.Error(), statusCode)`
`75`		`- } else {`
	`73`	`+ if options == nil {`
`76`	`74`	`http.Error(w, err.Error(), statusCode)`
	`75`	`+ return`
	`76`	`+ }`
	`77`	`+`
	`78`	`+ if options.ErrorHandler != nil {`
	`79`	`+ options.ErrorHandler(w, err.Error(), statusCode)`
`77`	`80`	`}`
`78`	`81`	`})`
`79`	`82`	`}`