Fix form/explode=false incorrectly splitting primitive string values on commas#119
Merged
mromaszewicz merged 3 commits intooapi-codegen:mainfrom Apr 8, 2026
Merged
Conversation
Resolve conflict in bindparam.go: keep the PR's primitive-type early-return (skip comma splitting for non-array/object types) and upstream's spaceDelimited/pipeDelimited style support. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The primitive-type early returns added for the explode=false fix guarantee that only Slice, Struct, and Map kinds reach the post-split switch. The default branches in both BindQueryParameterWithOptions and BindRawQueryParameter are now dead code — remove them. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mromaszewicz
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BindQueryParameterWithOptionsandBindRawQueryParameterunconditionally split query parameter values on commas whenexplode=false, even for primitive (non-array, non-object) destination types. This causesparameters like
scope=openid,profile,emailto fail with:Invalid format for parameter scope: multiple values for single value parameter 'scope'
Per the OpenAPI specification,
explodehas no effect on primitive types — the serialization is identical regardless of theexplodevalue:id=5id=5id=3&id=4&id=5id=3,4,5role=admin&firstName=Alexrole,admin,firstName,AlexComma splitting is only meaningful for array and object types.
Changes
bindparam.go: In bothBindQueryParameterWithOptionsandBindRawQueryParameter, check the destination type before splitting on commas. For primitive types (reflect.Kindis not Slice, Struct, orMap), bind the raw value directly without splitting.
How it was tested
BindQueryParameterwithform/explode=falsebinding a comma-containing string (required and optional variants)BindRawQueryParameterwithform/explode=falsebinding a percent-encoded comma-containing string (required and optional variants)Related
This is similar in spirit to #115 / #114, which fixed the same class of bug in
BindStyledParameterWithOptionsfor simple/form style parameters. This PR addresses the equivalent issue in the query parameterbinding functions.