Commit 4f8f946
fix(review): read the --open review URL from stderr (oasdiff >= v1.19.1)
oasdiff v1.19.1 (#1011) moved the "Opening <url>" line from stdout to stderr so
it can't corrupt piped --format json/yaml output. The action's --open run greps
the URL from stdout with `2>/dev/null`, so against v1.19.1 it found no URL,
emitted the misleading "couldn't upload, re-run" warning, and posted NO review
comment -- a silent break of the whole free-review link. Caught by the w3
encrypted-review e2e run against tufin/oasdiff:latest.
Merge stderr into the pipe (2>&1) so the URL is captured regardless of which
stream oasdiff prints it on. Works with both old (stdout) and new (stderr) oasdiff.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>1 parent c9dbb73 commit 4f8f946
2 files changed
Lines changed: 18 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
230 | 230 | | |
231 | 231 | | |
232 | 232 | | |
233 | | - | |
234 | | - | |
235 | | - | |
236 | | - | |
237 | | - | |
238 | | - | |
239 | | - | |
240 | | - | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
241 | 242 | | |
242 | 243 | | |
243 | 244 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
227 | 227 | | |
228 | 228 | | |
229 | 229 | | |
230 | | - | |
231 | | - | |
232 | | - | |
233 | | - | |
234 | | - | |
235 | | - | |
236 | | - | |
237 | | - | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
238 | 239 | | |
239 | 240 | | |
240 | 241 | | |
| |||
0 commit comments