Skip to content

Commit 5944c0d

Browse files
docs(review): drop stale "reuse the same semantic flags" comment
The sentence was a remnant of an abandoned approach and added no information (passing $flags to the --open run is plain from the code). Keep the part of the comment that still explains the real subtleties: --open prints the URL on stdout, the browser-open soft-fails in CI, we grep the URL by its path shape, and the run is tolerated as non-fatal. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent b303ef1 commit 5944c0d

2 files changed

Lines changed: 8 additions & 10 deletions

File tree

breaking/entrypoint.sh

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -218,11 +218,10 @@ if [ -n "$breaking_changes" ] && ! echo "$breaking_changes" | head -n 1 | grep -
218218
# "couldn't upload" warning below.
219219
echo "::notice::oasdiff: the side-by-side review isn't available in composed mode (-c). The breaking-change report above is unaffected."
220220
else
221-
# Reuse the same semantic flags as the diff above so the uploaded
222-
# comparison matches. --open prints the review URL on stdout; in CI
223-
# the browser-open step soft-fails. We grep the /review/e/ URL out by
224-
# its stable path shape (not by surrounding prose). Tolerate a
225-
# non-zero exit / no match so `set -e` doesn't abort the run.
221+
# --open prints the review URL on stdout; in CI the browser-open
222+
# step soft-fails. We grep the /review/e/ URL out by its stable path
223+
# shape (not by surrounding prose). Tolerate a non-zero exit / no
224+
# match so `set -e` doesn't abort the run.
226225
free_review_url=$(oasdiff breaking "$base" "$revision" $flags --open 2>/dev/null \
227226
| grep -oE 'https://[^[:space:]]+/review/e/[^[:space:]]+' | head -n 1) || true
228227
if [ -n "$free_review_url" ]; then

changelog/entrypoint.sh

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -223,11 +223,10 @@ if [ -n "$changes_json" ] && [ "$changes_json" != "[]" ]; then
223223
# "couldn't upload" warning below.
224224
echo "::notice::oasdiff: the side-by-side review isn't available in composed mode (-c). The changelog above is unaffected."
225225
else
226-
# Reuse the same semantic flags as the diff above so the uploaded
227-
# comparison matches. --open prints the review URL on stdout; in CI
228-
# the browser-open step soft-fails. We grep the /review/e/ URL out by
229-
# its stable path shape (not by surrounding prose). Tolerate a
230-
# non-zero exit / no match so `set -e` doesn't abort the run.
226+
# --open prints the review URL on stdout; in CI the browser-open
227+
# step soft-fails. We grep the /review/e/ URL out by its stable path
228+
# shape (not by surrounding prose). Tolerate a non-zero exit / no
229+
# match so `set -e` doesn't abort the run.
231230
free_review_url=$(oasdiff changelog "$base" "$revision" $flags --open 2>/dev/null \
232231
| grep -oE 'https://[^[:space:]]+/review/e/[^[:space:]]+' | head -n 1) || true
233232
if [ -n "$free_review_url" ]; then

0 commit comments

Comments
 (0)