Skip to content

Commit 5a09797

Browse files
fix: handle informational "No ..." messages from oasdiff v1.14.0
oasdiff v1.14.0 prints "No changes to report, but the specs are different" when the diff is non-empty but no breaking/changelog entries are found (e.g. all suppressed via --err-ignore). The entrypoint scripts treated any non-empty output as actual changes, which caused the ::notice:: upgrade link to fire incorrectly and the wrong output string. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent c4a6e86 commit 5a09797

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

breaking/entrypoint.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ oasdiff breaking "$base" "$revision" $flags_with_githubactions
9999
delimiter=$(cat /proc/sys/kernel/random/uuid | tr -d '-')
100100
echo "breaking<<$delimiter" >>"$GITHUB_OUTPUT"
101101

102-
if [ -n "$breaking_changes" ]; then
102+
if [ -n "$breaking_changes" ] && ! echo "$breaking_changes" | head -n 1 | grep -q "^No "; then
103103
write_output "$(echo "$breaking_changes" | head -n 1)" "$breaking_changes"
104104
# Emit upgrade notice pointing to the free review page
105105
urlencode() { printf '%s' "$1" | jq -sRr @uri; }

changelog/entrypoint.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ else
9797
output=$(oasdiff changelog "$base" "$revision")
9898
fi
9999

100-
if [ -n "$output" ]; then
100+
if [ -n "$output" ] && ! echo "$output" | head -n 1 | grep -q "^No "; then
101101
write_output "$output"
102102
else
103103
write_output "No changelog changes"

0 commit comments

Comments
 (0)