Skip to content

fix: handle informational messages from oasdiff v1.14.0 #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reuvenharrison merged 1 commit into from
Apr 12, 2026
Merged

fix: handle informational messages from oasdiff v1.14.0 #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion breaking/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ oasdiff breaking "$base" "$revision" $flags_with_githubactions
delimiter=$(cat /proc/sys/kernel/random/uuid | tr -d '-')
echo "breaking<<$delimiter" >>"$GITHUB_OUTPUT"

if [ -n "$breaking_changes" ]; then
if [ -n "$breaking_changes" ] && ! echo "$breaking_changes" | head -n 1 | grep -q "^No "; then
write_output "$(echo "$breaking_changes" | head -n 1)" "$breaking_changes"
# Emit upgrade notice pointing to the free review page
urlencode() { printf '%s' "$1" | jq -sRr @uri; }
Expand Down
2 changes: 1 addition & 1 deletion changelog/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ else
output=$(oasdiff changelog "$base" "$revision")
fi

if [ -n "$output" ]; then
if [ -n "$output" ] && ! echo "$output" | head -n 1 | grep -q "^No "; then
write_output "$output"
else
write_output "No changelog changes"
Expand Down
Loading