Skip to content

Commit 20be963

Browse files
fix: review suggestion, shorten verbose comment
1 parent 73bb52a commit 20be963

1 file changed

Lines changed: 1 addition & 8 deletions

File tree

build/rofl/manifest.go

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -539,14 +539,7 @@ func upgradeArtifacts(upgrade []artifactUpgrade) bool {
539539

540540
// upgradePossible checks if any explicitly configured artifact differs from the latest.
541541
//
542-
// This has intentionally different semantics than upgradeArtifacts:
543-
// - upgradeArtifacts: empty existing + non-empty new -> WRITES the new value
544-
// - upgradePossible: empty existing + non-empty new -> returns FALSE
545-
//
546-
// Rationale: When a manifest field is empty, the build uses the latest defaults
547-
// from code (LatestBasicArtifacts/LatestContainerArtifacts). So an empty field
548-
// means the user is already getting the latest, no notification needed. We only
549-
// notify when explicit overrides exist and are outdated.
542+
// In contrast to upgradeArtifacts() empty existing fields will be assumed as up-to-date.
550543
func upgradePossible(check []artifactUpgrade) bool {
551544
for _, artifact := range check {
552545
if artifact.new == "" {

0 commit comments

Comments
 (0)