Skip to content

feat(cmd/rofl): Implement deploy via ROFL market#422

Merged
kostko merged 3 commits intomasterfrom
kostko/feature/rofl-market
Apr 22, 2025
Merged

feat(cmd/rofl): Implement deploy via ROFL market#422
kostko merged 3 commits intomasterfrom
kostko/feature/rofl-market

Conversation

@kostko
Copy link
Copy Markdown
Member

@kostko kostko commented Apr 3, 2025

No description provided.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 3, 2025

Deploy Preview for oasisprotocol-cli canceled.

Name Link
🔨 Latest commit 15b9e2f
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-cli/deploys/68011522051340000831c362

@kostko kostko force-pushed the kostko/feature/rofl-market branch from 3c9309c to 4594a95 Compare April 10, 2025 11:44
@kostko kostko self-assigned this Apr 10, 2025
@kostko kostko added the rofl ROFL related CLI issues label Apr 10, 2025
@kostko kostko force-pushed the kostko/feature/rofl-market branch 3 times, most recently from f793ffc to 6a90176 Compare April 14, 2025 10:34
@kostko kostko force-pushed the kostko/feature/rofl-market branch 5 times, most recently from 131076c to 35b5af8 Compare April 14, 2025 13:42
@kostko kostko marked this pull request as ready for review April 14, 2025 13:55
@kostko kostko requested a review from matevz April 14, 2025 13:55
@kostko kostko force-pushed the kostko/feature/rofl-market branch from 35b5af8 to 7300a6d Compare April 15, 2025 08:09
Comment thread build/rofl/manifest.go Outdated
@kostko kostko force-pushed the kostko/feature/rofl-market branch 5 times, most recently from f757357 to e877ee8 Compare April 17, 2025 12:53
Comment thread build/env/env.go Outdated
Comment thread cmd/rofl/build/build.go
Comment thread cmd/rofl/common/term.go
Comment on lines +13 to +15
TermHour = "hour"
TermMonth = "month"
TermYear = "year"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TermHour = "hour"
TermMonth = "month"
TermYear = "year"
TermHour = "hourly"
TermMonth = "monthly"
TermYear = "yearly"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has already been renamed for the provider configuration, but I'm less sure about the --term option? E.g. in top-up you would say top-up --term month --term-count 1 to specify 1 month.

Comment thread cmd/rofl/deploy.go
Comment thread cmd/rofl/deploy.go Outdated
Comment thread cmd/rofl/deploy.go
@kostko kostko force-pushed the kostko/feature/rofl-market branch from e877ee8 to 59652bb Compare April 17, 2025 14:39
@kostko kostko force-pushed the kostko/feature/rofl-market branch from 59652bb to 15b9e2f Compare April 17, 2025 14:50
@kostko kostko merged commit a588a85 into master Apr 22, 2025
4 checks passed
@kostko kostko deleted the kostko/feature/rofl-market branch April 22, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rofl ROFL related CLI issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants