Skip to content

cmd&build: Push ORCs to Oasis-managed ROFL registry by default#442

Merged
anzoman merged 1 commit into
masterfrom
anzoman/use-default-rofl-orc-registry
May 6, 2025
Merged

cmd&build: Push ORCs to Oasis-managed ROFL registry by default#442
anzoman merged 1 commit into
masterfrom
anzoman/use-default-rofl-orc-registry

Conversation

@anzoman

@anzoman anzoman commented May 5, 2025

Copy link
Copy Markdown
Contributor

Previously, the CLI required configuring an OCI repository manually when using oasis rofl deploy. The changes here simplify this by introducing a default Oasis-managed OCI registry for pushing ROFL ORCs.

@netlify

netlify Bot commented May 5, 2025

Copy link
Copy Markdown

Deploy Preview for oasisprotocol-cli canceled.

Name Link
🔨 Latest commit 2401b3a
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-cli/deploys/6819f5a1e16f13000803291e

@anzoman anzoman force-pushed the anzoman/use-default-rofl-orc-registry branch from 76e9765 to ce7a490 Compare May 5, 2025 14:11
Comment thread cmd/rofl/deploy.go
@kostko kostko requested a review from matevz May 5, 2025 14:24
@anzoman anzoman force-pushed the anzoman/use-default-rofl-orc-registry branch from ce7a490 to 3ec59ad Compare May 5, 2025 15:21
@anzoman anzoman marked this pull request as ready for review May 5, 2025 16:01
@anzoman anzoman self-assigned this May 5, 2025

@matevz matevz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more suggestions, otherwise lgtm.

Comment thread build/rofl/oci.go Outdated
Comment thread cmd/rofl/deploy.go
@anzoman anzoman force-pushed the anzoman/use-default-rofl-orc-registry branch from 3ec59ad to 56ab0d3 Compare May 6, 2025 11:30
Comment thread cmd/rofl/deploy.go Outdated
@anzoman anzoman force-pushed the anzoman/use-default-rofl-orc-registry branch from 56ab0d3 to 7d8210e Compare May 6, 2025 11:41
cmd&build: Push ORCs to Oasis ROFL registry by default
@anzoman anzoman force-pushed the anzoman/use-default-rofl-orc-registry branch from 7d8210e to 2401b3a Compare May 6, 2025 11:42
@anzoman anzoman merged commit 1bf6936 into master May 6, 2025
4 checks passed
@anzoman anzoman deleted the anzoman/use-default-rofl-orc-registry branch May 6, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants