Skip to content

rofl deploy: Set default provider address, detect term and take the first offer#447

Merged
matevz merged 3 commits into
masterfrom
matevz/feature/default-provider-address-term-offer
May 6, 2025
Merged

rofl deploy: Set default provider address, detect term and take the first offer#447
matevz merged 3 commits into
masterfrom
matevz/feature/default-provider-address-term-offer

Conversation

@matevz

@matevz matevz commented May 6, 2025

Copy link
Copy Markdown
Member

This PR simplifies flow for first-time developers building ROFL on Testnet:

  • detects the term (month, day, year) based on the selected offer (rofl deploy: Autodetect term #441)
  • sets the default ROFL provider to oasis1qp2ens0hsp7gh23wajxa4hpetkdek3swyyulyrmz, if none provided (Oasis foundation-managed Testnet node)
  • if no offer provided, take the first one instead of throwing the error
  • adds --show-offers for listing offers and quit

Fixes #441

@netlify

netlify Bot commented May 6, 2025

Copy link
Copy Markdown

Deploy Preview for oasisprotocol-cli canceled.

Name Link
🔨 Latest commit bfc4f22
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-cli/deploys/6819d6d3fb6ab5000891c4d9

@matevz matevz requested review from anzoman and kostko May 6, 2025 08:16
Comment thread cmd/rofl/deploy.go Outdated
Comment thread cmd/rofl/deploy.go
Comment thread cmd/rofl/deploy.go
@matevz matevz force-pushed the matevz/feature/default-provider-address-term-offer branch from 02f291f to 248a55a Compare May 6, 2025 09:28
@matevz matevz force-pushed the matevz/feature/default-provider-address-term-offer branch from 248a55a to bfc4f22 Compare May 6, 2025 09:30
@matevz matevz requested a review from kostko May 6, 2025 09:32
@matevz matevz merged commit b09dcd2 into master May 6, 2025
4 checks passed
@matevz matevz deleted the matevz/feature/default-provider-address-term-offer branch May 6, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rofl deploy: Autodetect term

2 participants